[webkit-changes] [WebKit/WebKit] 302994: [TexMap] Damage rectangles are too big when scrolling

[Pawel Lampe]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 302994d3f3218b34e4669e6f9fa0dfab99c17982
      https://github.com/WebKit/WebKit/commit/302994d3f3218b34e4669e6f9fa0dfab99c17982
  Author: Pawel Lampe <plampe at igalia.com>
  Date:   2025-02-28 (Fri, 28 Feb 2025)

  Changed paths:
    M LayoutTests/platform/glib/TestExpectations
    M LayoutTests/platform/glib/damage/accelerated-canvas-2d-fillRect.html
    M LayoutTests/platform/glib/damage/scrolling-container-001.html
    M LayoutTests/platform/glib/damage/scrolling-container-003.html
    M LayoutTests/platform/glib/damage/scrolling-container-004.html
    M LayoutTests/platform/wpe/TestExpectations
    M Source/WebCore/platform/graphics/texmap/TextureMapper.cpp
    M Source/WebCore/platform/graphics/texmap/TextureMapper.h
    M Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp

  Log Message:
  -----------
  [TexMap] Damage rectangles are too big when scrolling
https://bugs.webkit.org/show_bug.cgi?id=288468

Reviewed by Carlos Garcia Campos.

This change fixes the damage rectangles generated on scrolling
by maintaining a clipping rect and using it to clip those
based on the layer ancestors.

Also, this change fixes a few layout tests that were not correct
in the sense that they could be affected by scrollbars
depending on the platform the tests were run on.

* LayoutTests/platform/glib/TestExpectations:
* LayoutTests/platform/glib/damage/accelerated-canvas-2d-fillRect.html:
* LayoutTests/platform/glib/damage/scrolling-container-001.html:
* LayoutTests/platform/glib/damage/scrolling-container-003.html:
* LayoutTests/platform/glib/damage/scrolling-container-004.html:
* LayoutTests/platform/wpe/TestExpectations:
* Source/WebCore/platform/graphics/texmap/TextureMapper.cpp:
(WebCore::TextureMapper::beginClipWithoutApplying):
(WebCore::TextureMapper::endClipWithoutApplying):
* Source/WebCore/platform/graphics/texmap/TextureMapper.h:
* Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp:
(WebCore::TextureMapperLayer::collectDamageSelfAndChildren):
(WebCore::TextureMapperLayer::collectDamageSelf):

Canonical link: https://commits.webkit.org/291382@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications