[webkit-changes] [WebKit/WebKit] f6c402: Support multiple stylesheets in the media controls...

aestes noreply at github.com
Fri Feb 28 10:38:01 PST 2025


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f6c402be75a06084d64e11ffe23eb4012f98acf9
      https://github.com/WebKit/WebKit/commit/f6c402be75a06084d64e11ffe23eb4012f98acf9
  Author: Andy Estes <aestes at apple.com>
  Date:   2025-02-28 (Fri, 28 Feb 2025)

  Changed paths:
    M Source/WebCore/Modules/mediacontrols/MediaControlsHost.cpp
    M Source/WebCore/Modules/mediacontrols/MediaControlsHost.h
    M Source/WebCore/Modules/mediacontrols/MediaControlsHost.idl
    M Source/WebCore/Modules/modern-media-controls/main.js
    M Source/WebCore/rendering/RenderTheme.h
    M Source/WebCore/rendering/adwaita/RenderThemeAdwaita.cpp
    M Source/WebCore/rendering/adwaita/RenderThemeAdwaita.h
    M Source/WebCore/rendering/cocoa/RenderThemeCocoa.h
    M Source/WebCore/rendering/cocoa/RenderThemeCocoa.mm

  Log Message:
  -----------
  Support multiple stylesheets in the media controls shadow root
https://bugs.webkit.org/show_bug.cgi?id=288764
rdar://145789376

Reviewed by Aditya Keerthi.

Added the ability for media controls' shadow root to contain multiple <style> elements.

* Source/WebCore/Modules/mediacontrols/MediaControlsHost.cpp:
(WebCore::MediaControlsHost::shadowRootStyleSheets):
* Source/WebCore/Modules/mediacontrols/MediaControlsHost.h:
* Source/WebCore/Modules/mediacontrols/MediaControlsHost.idl:
Renamed from shadowRootCSSText. Changed to return a Vector<String>.

* Source/WebCore/Modules/modern-media-controls/main.js:
(createControls):
Inserted a <style> element for each item in host.shadowRootStyleSheets.

* Source/WebCore/rendering/RenderTheme.h:
(WebCore::RenderTheme::mediaControlsStyleSheets):
* Source/WebCore/rendering/adwaita/RenderThemeAdwaita.cpp:
(WebCore::RenderThemeAdwaita::mediaControlsStyleSheets):
(WebCore::RenderThemeAdwaita::mediaControlsStyleSheet): Deleted.
* Source/WebCore/rendering/adwaita/RenderThemeAdwaita.h:
* Source/WebCore/rendering/cocoa/RenderThemeCocoa.h:
* Source/WebCore/rendering/cocoa/RenderThemeCocoa.mm:
(WebCore::additionalMediaControlsStyleSheets):
(WebCore::RenderThemeCocoa::mediaControlsStyleSheets):
Renamed from mediaControlsStyleSheet. Changed to return a Vector<String> containing
m_mediaControlsStyleSheet and the style sheets from additionalMediaControlsStyleSheets().

Canonical link: https://commits.webkit.org/291343@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list