[webkit-changes] [WebKit/WebKit] 770d25: Address a lot of Safer CPP failures in webpushd

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 770d25a8375298cb04767662418738016bca5ec7
      https://github.com/WebKit/WebKit/commit/770d25a8375298cb04767662418738016bca5ec7
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2025-02-28 (Fri, 28 Feb 2025)

  Changed paths:
    M Source/WTF/wtf/Deque.h
    M Source/WebKit/SaferCPPExpectations/UncountedCallArgsCheckerExpectations
    M Source/WebKit/SaferCPPExpectations/UncountedLambdaCapturesCheckerExpectations
    M Source/WebKit/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations
    M Source/WebKit/webpushd/ApplePushServiceConnection.mm
    M Source/WebKit/webpushd/PushService.h
    M Source/WebKit/webpushd/PushService.mm
    M Source/WebKit/webpushd/PushServiceConnection.mm
    M Source/WebKit/webpushd/WebPushDaemon.h
    M Source/WebKit/webpushd/WebPushDaemon.mm

  Log Message:
  -----------
  Address a lot of Safer CPP failures in webpushd
https://bugs.webkit.org/show_bug.cgi?id=288789

Reviewed by Ryosuke Niwa.

* Source/WebKit/SaferCPPExpectations/UncountedCallArgsCheckerExpectations:
* Source/WebKit/SaferCPPExpectations/UncountedLambdaCapturesCheckerExpectations:
* Source/WebKit/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations:
* Source/WebKit/webpushd/ApplePushServiceConnection.mm:
(-[_WKAPSConnectionDelegate connection:didReceivePublicToken:]):
(-[_WKAPSConnectionDelegate connection:didReceiveIncomingMessage:]):
(WebPushD::ApplePushServiceConnection::subscribe):
(WebPushD::ApplePushServiceConnection::unsubscribe):
* Source/WebKit/webpushd/PushService.h:
(WebPushD::PushService::enabledTopics):
(WebPushD::PushService::ignoredTopics):
* Source/WebKit/webpushd/PushService.mm:
(WebPushD::PushService::create):
(WebPushD::SubscribeRequest::attemptToRecoverFromTopicAlreadyInFilterError):
* Source/WebKit/webpushd/PushServiceConnection.mm:
(WebPushD::PushServiceConnection::startListeningForPushMessages):
* Source/WebKit/webpushd/WebPushDaemon.h:
* Source/WebKit/webpushd/WebPushDaemon.mm:
(WebPushD::WebPushDaemon::startMockPushService):
(WebPushD::WebPushDaemon::startPushService):
(WebPushD::WebPushDaemon::setPushService):
(WebPushD::WebPushDaemon::updateSubscriptionSetState):
(WebPushD::WebPushDaemon::setPushAndNotificationsEnabledForOrigin):
(WebPushD::WebPushDaemon::injectEncryptedPushMessageForTesting):
(WebPushD::WebPushDaemon::handleIncomingPush):
(WebPushD::WebPushDaemon::getPushTopicsForTesting):
(WebPushD::WebPushDaemon::subscribeToPushService):
(WebPushD::WebPushDaemon::unsubscribeFromPushService):
(WebPushD::WebPushDaemon::getPushSubscription):
(WebPushD::WebPushDaemon::incrementSilentPushCount):
(WebPushD::WebPushDaemon::removeAllPushSubscriptions):
(WebPushD::WebPushDaemon::removePushSubscriptionsForOrigin):
(WebPushD::WebPushDaemon::setPublicTokenForTesting):
(WebPushD::WebPushDaemon::showNotification):

Canonical link: https://commits.webkit.org/291336@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications