[webkit-changes] [WebKit/WebKit] 7ba448: [GStreamer] Incorrect uses of StringView::rawChara...

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7ba4483acaf38329bba83674800556262c1fedac
      https://github.com/WebKit/WebKit/commit/7ba4483acaf38329bba83674800556262c1fedac
  Author: Philippe Normand <philn at igalia.com>
  Date:   2025-02-28 (Fri, 28 Feb 2025)

  Changed paths:
    M Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.cpp
    M Source/WebCore/platform/graphics/gstreamer/VideoEncoderGStreamer.cpp
    M Source/WebCore/platform/graphics/gstreamer/eme/WebKitCommonEncryptionDecryptorGStreamer.cpp
    M Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp

  Log Message:
  -----------
  [GStreamer] Incorrect uses of StringView::rawCharacters()
https://bugs.webkit.org/show_bug.cgi?id=286527

Reviewed by Xabier Rodriguez-Calvar.

Our use of StringView::rawCharacters() is incorrect, its value being lifetime bound, so instead,
convert the StringView to a local CString and refer to its data.

* Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.cpp:
(WebCore::GStreamerRegistryScanner::isContentTypeSupported const):
* Source/WebCore/platform/graphics/gstreamer/VideoEncoderGStreamer.cpp:
(WebCore::retrieveTemporalIndex):
* Source/WebCore/platform/graphics/gstreamer/eme/WebKitCommonEncryptionDecryptorGStreamer.cpp:
(transformCaps):
* Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp:
(WebCore::AppendPipeline::appsinkCapsChanged):

Canonical link: https://commits.webkit.org/291316@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications