[webkit-changes] [WebKit/WebKit] 2bd73e: [scroll-animations] obtaining view timeline `sourc...

[Antoine Quint]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2bd73e9036d6bf9fd2d9acd8b2da71dbc01b3193
      https://github.com/WebKit/WebKit/commit/2bd73e9036d6bf9fd2d9acd8b2da71dbc01b3193
  Author: Antoine Quint <graouts at webkit.org>
  Date:   2025-02-28 (Fri, 28 Feb 2025)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/scroll-animations/view-timelines/unattached-subject-inset-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/scroll-animations/view-timelines/view-timeline-source.tentative-expected.txt
    M Source/WebCore/animation/ScrollTimeline.cpp
    M Source/WebCore/animation/ScrollTimeline.h
    M Source/WebCore/animation/ScrollTimeline.idl
    M Source/WebCore/animation/ViewTimeline.cpp
    M Source/WebCore/animation/ViewTimeline.h

  Log Message:
  -----------
  [scroll-animations] obtaining view timeline `source` from bindings should trigger a style recalc
https://bugs.webkit.org/show_bug.cgi?id=288781

Reviewed by Cameron McCormack.

The source of a view timeline is dependent on style-related information. Indeed, since only the
view timeline subject is provided, the source is determined as the nearest scroller to that element
and pending CSS changes could make a difference.

To address this, we add a dedicated method for when the source is queried via the bindings and trigger
a style recalc in that case alone. This fixes 3 failing WPT subtests and 2 failing WPT files.

* LayoutTests/imported/w3c/web-platform-tests/scroll-animations/view-timelines/unattached-subject-inset-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/scroll-animations/view-timelines/view-timeline-source.tentative-expected.txt:
* Source/WebCore/animation/ScrollTimeline.cpp:
(WebCore::ScrollTimeline::bindingsSource const):
* Source/WebCore/animation/ScrollTimeline.h:
* Source/WebCore/animation/ScrollTimeline.idl:
* Source/WebCore/animation/ViewTimeline.cpp:
(WebCore::ViewTimeline::bindingsSource const):
* Source/WebCore/animation/ViewTimeline.h:

Canonical link: https://commits.webkit.org/291310@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications