[webkit-changes] [WebKit/WebKit] 37f0b2: [scroll-animations] WPT test `scroll-animations/cs...

[Antoine Quint]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 37f0b2e5f42205da011e18eb062169328b4c2960
      https://github.com/WebKit/WebKit/commit/37f0b2e5f42205da011e18eb062169328b4c2960
  Author: Antoine Quint <graouts at webkit.org>
  Date:   2025-02-27 (Thu, 27 Feb 2025)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/timeline-scope-expected.txt
    M Source/WebCore/animation/StyleOriginatedTimelinesController.cpp

  Log Message:
  -----------
  [scroll-animations] WPT test `scroll-animations/css/timeline-scope.html` is a failure
https://bugs.webkit.org/show_bug.cgi?id=288755

Reviewed by Dean Jackson.

When a `timeline-scope: none` value is set, we must make sure to unregister all timelines
that were previously created for a name within that scope.

Then, if an animation has its `animation-timeline` set to a value that has not yet resolved
to a scoped name, we must keep it in the list of pending animations such that if we move to
a value other then `timeline-scope: none`, this timeline name may resolve dynamically.

* LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/timeline-scope-expected.txt:
* Source/WebCore/animation/StyleOriginatedTimelinesController.cpp:
(WebCore::StyleOriginatedTimelinesController::attachAnimation):
(WebCore::StyleOriginatedTimelinesController::updateNamedTimelineMapForTimelineScope):

Canonical link: https://commits.webkit.org/291303@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications