[webkit-changes] [WebKit/WebKit] 18e960: [iOS] [UnifiedPDF] Add an API test for https://com...

[Wenson Hsieh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 18e960157ccc5439ae85b47d796fdaed9fe97cba
      https://github.com/WebKit/WebKit/commit/18e960157ccc5439ae85b47d796fdaed9fe97cba
  Author: Wenson Hsieh <wenson_hsieh at apple.com>
  Date:   2025-02-27 (Thu, 27 Feb 2025)

  Changed paths:
    M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFPresentationController.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/UnifiedPDFTests.mm

  Log Message:
  -----------
  [iOS] [UnifiedPDF] Add an API test for https://commits.webkit.org/291223@main
https://bugs.webkit.org/show_bug.cgi?id=288740
rdar://143047345

Reviewed by Abrar Rahman Protyasha.

Add an API test for the changes in 291223 at main, by loading a multi-page PDF in a web view and
resizing it from (800, 600) → (600, 800) → (800, 600) → (600, 800). Verify that the web view's
scroll content offset toggles between two consistent values, for the two dimensions.

* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFPresentationController.mm:
(WebKit::PDFPresentationController::pdfPositionForCurrentView const):

Drive-by fix: revert an unintentional behavior change in 291223 at main. When sizing the plugin width
to fit the root view, we want to use the top left as the `pdfPositionForCurrentView` instead of
the top center point.

* Tools/TestWebKitAPI/Tests/WebKitCocoa/UnifiedPDFTests.mm:
(TestWebKitAPI::UNIFIED_PDF_TEST):

Canonical link: https://commits.webkit.org/291259@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications