[webkit-changes] [WebKit/WebKit] 3af19d: Enabling scoped custom element registry breaks car...

[Ryosuke Niwa]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3af19d7c293235ec4eb57ec2b5edfc9d5045f039
      https://github.com/WebKit/WebKit/commit/3af19d7c293235ec4eb57ec2b5edfc9d5045f039
  Author: Ryosuke Niwa <rniwa at webkit.org>
  Date:   2025-02-27 (Thu, 27 Feb 2025)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/custom-elements/revamped-scoped-registry/ShadowRoot-init-customElements.tentative-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/custom-elements/revamped-scoped-registry/ShadowRoot-init-customElements.tentative.html
    A LayoutTests/imported/w3c/web-platform-tests/custom-elements/revamped-scoped-registry/polymer-polyfill-regression.tentative-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/custom-elements/revamped-scoped-registry/polymer-polyfill-regression.tentative.html
    M Source/WebCore/dom/Element.cpp
    M Source/WebCore/dom/ShadowRoot.idl
    M Source/WebCore/dom/ShadowRootInit.h
    M Source/WebCore/dom/ShadowRootInit.idl

  Log Message:
  -----------
  Enabling scoped custom element registry breaks carmax.com
https://bugs.webkit.org/show_bug.cgi?id=288710

Reviewed by Anne van Kesteren.

The regression was caused by Polymer's polyfill for scoped custom element registry.

Workaround the issue by allowing customElements to be of any type in ShadowRootInit,
and making ShadowRoot.prototype.customElements replaceable by author scripts.

* LayoutTests/imported/w3c/web-platform-tests/custom-elements/revamped-scoped-registry/CustomElementRegistry-initialize.tentative.html:
* LayoutTests/imported/w3c/web-platform-tests/custom-elements/revamped-scoped-registry/ShadowRoot-init-customElements.tentative-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/custom-elements/revamped-scoped-registry/ShadowRoot-init-customElements.tentative.html:
* Source/WebCore/dom/Element.cpp:
* Source/WebCore/dom/ShadowRoot.idl:
* Source/WebCore/dom/ShadowRootInit.h:
* Source/WebCore/dom/ShadowRootInit.idl:

Canonical link: https://commits.webkit.org/291247@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications