[webkit-changes] [WebKit/WebKit] 055780: REGRESSION(290260 at main): [Win] WebInspector can't ...

[Fujii Hironori]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0557803fbb594adc8e1a3704820b3825e1127a6e
      https://github.com/WebKit/WebKit/commit/0557803fbb594adc8e1a3704820b3825e1127a6e
  Author: Fujii Hironori <Hironori.Fujii at sony.com>
  Date:   2025-02-26 (Wed, 26 Feb 2025)

  Changed paths:
    M Source/WebKit/UIProcess/Inspector/WebInspectorUIProxy.h
    M Source/WebKit/UIProcess/Inspector/win/WebInspectorUIProxyWin.cpp

  Log Message:
  -----------
  REGRESSION(290260 at main): [Win] WebInspector can't be attached to the inspected window
https://bugs.webkit.org/show_bug.cgi?id=288395

Unreviewed fix.

After <https://commits.webkit.org/290260@main>, WebInspector never
started as attached to the window. It always opened a new inspector
window.

<https://commits.webkit.org/290937@main> fixed the problem for GTK
port. WebInspectorUIProxy::platformCanAttach has to be implemented for
Windows port too.

* Source/WebKit/UIProcess/Inspector/WebInspectorUIProxy.h:
* Source/WebKit/UIProcess/Inspector/win/WebInspectorUIProxyWin.cpp:
(WebKit::WebInspectorUIProxy::platformCanAttach):
(WebKit::WebInspectorUIProxy::platformAttach):

Canonical link: https://commits.webkit.org/291202@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications