[webkit-changes] [WebKit/WebKit] cfca39: Remove WaitForNotificationBeforeInjecting and frie...

[Timothy Hatcher]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cfca39e354fcc088fd855a64c1c94e9b120596a4
      https://github.com/WebKit/WebKit/commit/cfca39e354fcc088fd855a64c1c94e9b120596a4
  Author: Timothy Hatcher <timothy at apple.com>
  Date:   2025-02-26 (Wed, 26 Feb 2025)

  Changed paths:
    M Source/WebCore/page/LocalFrame.cpp
    M Source/WebCore/page/LocalFrame.h
    M Source/WebCore/page/Page.cpp
    M Source/WebCore/page/Page.h
    M Source/WebCore/page/PageConfiguration.h
    M Source/WebCore/page/Quirks.cpp
    M Source/WebCore/page/UserScript.cpp
    M Source/WebCore/page/UserScript.h
    M Source/WebCore/page/UserScriptTypes.h
    M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in
    M Source/WebKit/Shared/WebPageCreationParameters.h
    M Source/WebKit/Shared/WebPageCreationParameters.serialization.in
    M Source/WebKit/UIProcess/API/APIPageConfiguration.h
    M Source/WebKit/UIProcess/API/C/WKUserScriptRef.cpp
    M Source/WebKit/UIProcess/API/Cocoa/WKUserScript.mm
    M Source/WebKit/UIProcess/API/Cocoa/WKUserScriptPrivate.h
    M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
    M Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm
    M Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h
    M Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h
    M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm
    M Source/WebKit/UIProcess/WebPageProxy.cpp
    M Source/WebKit/UIProcess/WebPageProxy.h
    M Source/WebKit/WebProcess/WebPage/WebPage.cpp
    M Source/WebKit/WebProcess/WebPage/WebPage.h
    M Source/WebKit/WebProcess/WebPage/WebPage.messages.in
    M Source/WebKitLegacy/mac/WebView/WebView.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm

  Log Message:
  -----------
  Remove WaitForNotificationBeforeInjecting and friends.
https://webkit.org/b/288647
rdar://problem/145689560

Reviewed by Alex Christensen.

Remove this support since it is no longer used by any clients.

* Source/WebCore/page/LocalFrame.cpp:
(WebCore::LocalFrame::injectUserScripts):
(WebCore::LocalFrame::addUserScriptAwaitingNotification): Deleted.
(WebCore::LocalFrame::injectUserScriptsAwaitingNotification): Deleted.
* Source/WebCore/page/LocalFrame.h:
* Source/WebCore/page/Page.cpp:
(WebCore::m_presentingApplicationBundleIdentifier):
(WebCore::Page::notifyToInjectUserScripts): Deleted.
* Source/WebCore/page/Page.h:
(WebCore::Page::hasBeenNotifiedToInjectUserScripts const): Deleted.
* Source/WebCore/page/PageConfiguration.h:
* Source/WebCore/page/Quirks.cpp:
(WebCore::Quirks::triggerOptionalStorageAccessQuirk const):
* Source/WebCore/page/UserScript.cpp:
(WebCore::UserScript::UserScript):
* Source/WebCore/page/UserScript.h:
(WebCore::UserScript::injectedFrames const):
(WebCore::UserScript::waitForNotificationBeforeInjecting const): Deleted.
* Source/WebCore/page/UserScriptTypes.h:
* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:
* Source/WebKit/Shared/WebPageCreationParameters.h:
* Source/WebKit/Shared/WebPageCreationParameters.serialization.in:
* Source/WebKit/UIProcess/API/APIPageConfiguration.h:
(API::PageConfiguration::userScriptsShouldWaitUntilNotification const): Deleted.
(API::PageConfiguration::setUserScriptsShouldWaitUntilNotification): Deleted.
* Source/WebKit/UIProcess/API/C/WKUserScriptRef.cpp:
(WKUserScriptCreate):
(WKUserScriptCreateWithSource):
* Source/WebKit/UIProcess/API/Cocoa/WKUserScript.mm:
(-[WKUserScript _initWithSource:injectionTime:forMainFrameOnly:includeMatchPatternStrings:excludeMatchPatternStrings:associatedURL:contentWorld:deferRunningUntilNotification:]): Deprecated.
(-[WKUserScript _initWithSource:injectionTime:forMainFrameOnly:includeMatchPatternStrings:excludeMatchPatternStrings:associatedURL:contentWorld:]): Added.
* Source/WebKit/UIProcess/API/Cocoa/WKUserScriptPrivate.h:
* Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _notifyUserScripts]): Deleted.
(-[WKWebView _deferrableUserScriptsNeedNotification]): Deleted.
* Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
(-[WKWebViewConfiguration _deferrableUserScriptsShouldWaitUntilNotification]): Deleted.
(-[WKWebViewConfiguration _setDeferrableUserScriptsShouldWaitUntilNotification:]): Deleted.
* Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:
* Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h:
* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm:
(WebKit::WebExtensionContext::addInjectedContent):
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::creationParameters):
(WebKit::WebPageProxy::notifyUserScripts): Deleted.
(WebKit::WebPageProxy::userScriptsNeedNotification const): Deleted.
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::m_textAnimationController):
(WebKit::WebPage::addUserScript):
(WebKit::WebPage::notifyUserScripts): Deleted.
* Source/WebKit/WebProcess/WebPage/WebPage.h:
* Source/WebKit/WebProcess/WebPage/WebPage.messages.in:
* Source/WebKitLegacy/mac/WebView/WebView.mm:
(-[WebView _injectLaBanquePostaleQuirks]):
(+[WebView _addUserScriptToGroup:world:source:url:includeMatchPatternStrings:excludeMatchPatternStrings:injectionTime:injectedFrames:]):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
(TEST(WKUserContentController, UserScriptNotification)): Deleted.

Canonical link: https://commits.webkit.org/291165@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications