[webkit-changes] [WebKit/WebKit] 6dd21d: objectIsRelayoutBoundary doesn't account for basel...

[mattwoodrow]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6dd21dc9f928997631d9ee4165db98be40001af3
      https://github.com/WebKit/WebKit/commit/6dd21dc9f928997631d9ee4165db98be40001af3
  Author: Matt Woodrow <mattwoodrow at apple.com>
  Date:   2025-02-26 (Wed, 26 Feb 2025)

  Changed paths:
    A LayoutTests/fast/layout/relayout-boundary-inside-flex-expected.html
    A LayoutTests/fast/layout/relayout-boundary-inside-flex.html
    A LayoutTests/fast/layout/relayout-boundary-inside-inline-expected.html
    A LayoutTests/fast/layout/relayout-boundary-inside-inline.html
    M Source/WebCore/rendering/RenderObject.cpp

  Log Message:
  -----------
  objectIsRelayoutBoundary doesn't account for baseline changes across the boundary.
https://bugs.webkit.org/show_bug.cgi?id=288421
<rdar://145515762>

Reviewed by Alan Baradlay.

Being an independent formatting context isn't sufficient to be a layout
boundary, as placement within the formatting context can affect the baseline
positioning of things outside.

We need to prevent these being treated as boundaries if they are inside an
formatting context that uses baselines.

Caches the lookup of nearest ancestor baseline formatting context to prevent extra
ancestor walks during markContainingBlocksForLayout.

* LayoutTests/fast/layout/relayout-boundary-inside-flex-expected.html: Added.
* LayoutTests/fast/layout/relayout-boundary-inside-flex.html: Added.
* LayoutTests/fast/layout/relayout-boundary-inside-inline-expected.html: Added.
* LayoutTests/fast/layout/relayout-boundary-inside-inline.html: Added.
* Source/WebCore/rendering/RenderObject.cpp:
(WebCore::nearestBaselineContextAncestor):
(WebCore::objectIsRelayoutBoundary):
(WebCore::RenderObject::markContainingBlocksForLayout):

Canonical link: https://commits.webkit.org/291150@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications