[webkit-changes] [WebKit/WebKit] 22f025: [fullscreen] `document-exit-fullscreen-nested-in-i...

Alex Christensen noreply at github.com
Wed Feb 26 11:00:30 PST 2025


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 22f02541e39c8d3ca0114c5b00c249783a5dae47
      https://github.com/WebKit/WebKit/commit/22f02541e39c8d3ca0114c5b00c249783a5dae47
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2025-02-26 (Wed, 26 Feb 2025)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/fullscreen/api/document-exit-fullscreen-nested-in-iframe-expected.txt
    M Source/WebCore/dom/DocumentFullscreen.cpp

  Log Message:
  -----------
  [fullscreen] `document-exit-fullscreen-nested-in-iframe.html` WPT regressed after 290822 at main
https://bugs.webkit.org/show_bug.cgi?id=288578
rdar://145633558

Reviewed by Alex Christensen.

We were checking isSimpleFullscreenDocument on the wrong document.
I changed the implementation to start iteration at the current frame and go up,
always add the first document inside the loop, and then check the exit conditions.

* LayoutTests/imported/w3c/web-platform-tests/fullscreen/api/document-exit-fullscreen-nested-in-iframe-expected.txt:
* Source/WebCore/dom/DocumentFullscreen.cpp:
(WebCore::documentsToUnfullscreen):

Canonical link: https://commits.webkit.org/291147@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list