[webkit-changes] [WebKit/WebKit] a638a6: [scroll-animations] remove the `TimelineMapAttachO...

[Antoine Quint]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a638a633a78c7876ed9b8ecea2b84a9e42be707e
      https://github.com/WebKit/WebKit/commit/a638a633a78c7876ed9b8ecea2b84a9e42be707e
  Author: Antoine Quint <graouts at webkit.org>
  Date:   2025-02-25 (Tue, 25 Feb 2025)

  Changed paths:
    M Source/WebCore/animation/CSSAnimation.cpp
    M Source/WebCore/animation/StyleOriginatedTimelinesController.cpp
    M Source/WebCore/animation/StyleOriginatedTimelinesController.h

  Log Message:
  -----------
  [scroll-animations] remove the `TimelineMapAttachOperation` struct
https://bugs.webkit.org/show_bug.cgi?id=288537

Reviewed by Dean Jackson.

The `TimelineMapAttachOperation` struct is used to keep track of pending attachment operations for
CSS animations using the `animation-timeline` property. That structs contains the timeline name,
the target styleable and the CSS animation. But the names and targets can be obtained directly
from the CSS animation, so we can keep track of the CSS animations alone.

* Source/WebCore/animation/CSSAnimation.cpp:
(WebCore::CSSAnimation::syncStyleOriginatedTimeline):
* Source/WebCore/animation/StyleOriginatedTimelinesController.cpp:
(WebCore::StyleOriginatedTimelinesController::removePendingOperationsForCSSAnimation):
(WebCore::StyleOriginatedTimelinesController::documentDidResolveStyle):
(WebCore::StyleOriginatedTimelinesController::attachAnimation):
(WebCore::StyleOriginatedTimelinesController::isPendingTimelineAttachment const):
(WebCore::StyleOriginatedTimelinesController::styleableWasRemoved):
(WebCore::StyleOriginatedTimelinesController::setTimelineForName): Deleted.
* Source/WebCore/animation/StyleOriginatedTimelinesController.h:

Canonical link: https://commits.webkit.org/291098@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications