[webkit-changes] [WebKit/WebKit] be9370: Refactoring: rename FullscreenManager to DocumentF...

Tue Feb 25 21:55:53 PST 2025

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: be9370a1451a1af3a6a380ffc37e1081c34cdc53
      https://github.com/WebKit/WebKit/commit/be9370a1451a1af3a6a380ffc37e1081c34cdc53
  Author: Tim Nguyen <ntim at apple.com>
  Date:   2025-02-25 (Tue, 25 Feb 2025)

  Changed paths:
    M LayoutTests/media/media-fullscreen.js
    M Source/WebCore/Headers.cmake
    M Source/WebCore/SaferCPPExpectations/UncountedCallArgsCheckerExpectations
    M Source/WebCore/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations
    M Source/WebCore/Sources.txt
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    M Source/WebCore/css/SelectorCheckerTestFunctions.h
    M Source/WebCore/dom/Document+Fullscreen.idl
    M Source/WebCore/dom/Document.cpp
    M Source/WebCore/dom/Document.h
    M Source/WebCore/dom/DocumentFullscreen.cpp
    M Source/WebCore/dom/DocumentFullscreen.h
    M Source/WebCore/dom/DocumentOrShadowRootFullscreen.cpp
    M Source/WebCore/dom/Element.cpp
    M Source/WebCore/dom/EventPath.cpp
    R Source/WebCore/dom/FullscreenManager.cpp
    R Source/WebCore/dom/FullscreenManager.h
    M Source/WebCore/html/HTMLMediaElement.cpp
    M Source/WebCore/html/MediaElementSession.cpp
    M Source/WebCore/html/shadow/MediaControlTextTrackContainerElement.cpp
    M Source/WebCore/inspector/agents/InspectorDOMAgent.cpp
    M Source/WebCore/page/EventHandler.cpp
    M Source/WebCore/page/LocalFrameView.cpp
    M Source/WebCore/page/Page.cpp
    M Source/WebCore/page/ScreenOrientation.cpp
    M Source/WebCore/page/ios/ContentChangeObserver.cpp
    M Source/WebCore/rendering/RenderLayerBacking.cpp
    M Source/WebCore/rendering/RenderLayerCompositor.cpp
    M Source/WebCore/rendering/RenderVideo.cpp
    M Source/WebCore/style/StyleAdjuster.cpp
    M Source/WebCore/style/StyleSharingResolver.cpp
    M Source/WebCore/style/UserAgentStyle.cpp
    M Source/WebCore/testing/Internals.cpp
    M Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp
    M Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMDocumentGtk.cpp
    M Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp
    M Source/WebKit/WebProcess/WebCoreSupport/WebLocalFrameLoaderClient.cpp
    M Source/WebKit/WebProcess/WebPage/WebPage.cpp
    M Source/WebKitLegacy/mac/DOM/DOMDocument.mm
    M Source/WebKitLegacy/mac/WebCoreSupport/WebChromeClient.mm
    M Source/WebKitLegacy/mac/WebCoreSupport/WebKitFullScreenListener.mm
    M Source/WebKitLegacy/mac/WebView/WebFullScreenController.mm
    M Source/WebKitLegacy/mac/WebView/WebView.mm

  Log Message:
  -----------
  Refactoring: rename FullscreenManager to DocumentFullscreen
https://bugs.webkit.org/show_bug.cgi?id=259978
rdar://113633238

Reviewed by Jer Noble.

FullscreenManager is an implementation of a IDL extension called Document+Fullscreen.
We already have a DocumentFullscreen.cpp/h file which calls out to FullscreenManager.
And so the name "FullscreenManager" is not strictly correct. It doesn't "manage" fullscreen;
it's merely a way to collect Document's fullscreen implementation into a separate class.

Rename FullscreenManager to DocumentFullscreen and move its implementation into the existing
DocumentFullscreen.cpp/h files. Rename Document::fullscreenManager() to just Document::fullscreen().

No functional changes here, just renames, so covered by existing tests.

* LayoutTests/media/media-fullscreen.js:
(async beginfullscreen):
* Source/WebCore/Headers.cmake:
* Source/WebCore/SaferCPPExpectations/UncountedCallArgsCheckerExpectations:
* Source/WebCore/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations:
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/css/SelectorCheckerTestFunctions.h:
(WebCore::matchesAnimatingFullscreenTransitionPseudoClass):
(WebCore::matchesFullscreenDocumentPseudoClass):
(WebCore::matchesInWindowFullscreenPseudoClass):
* Source/WebCore/dom/Document+Fullscreen.idl:
* Source/WebCore/dom/Document.cpp:
(WebCore::m_syncData):
(WebCore::Document::commonTeardown):
(WebCore::Document::ensureFullscreen):
(WebCore::Document::fullscreen):
(WebCore::Document::fullscreen const):
(WebCore::Document::checkedFullscreen):
(WebCore::Document::checkedFullscreen const):
(WebCore::eventTargetElementForDocument):
(WebCore::Document::ensureFullscreenManager): Deleted.
(WebCore::Document::fullscreenManager): Deleted.
(WebCore::Document::fullscreenManager const): Deleted.
(WebCore::Document::checkedFullscreenManager): Deleted.
(WebCore::Document::checkedFullscreenManager const): Deleted.
* Source/WebCore/dom/Document.h:
(WebCore::Document::fullscreenIfExists):
(WebCore::Document::fullscreenIfExists const):
(WebCore::Document::fullscreenManagerIfExists): Deleted.
(WebCore::Document::fullscreenManagerIfExists const): Deleted.
* Source/WebCore/dom/DocumentFullscreen.cpp:
(WebCore::DocumentFullscreen::DocumentFullscreen):
(WebCore::DocumentFullscreen::fullscreenEnabled):
(WebCore::DocumentFullscreen::isFullscreenEnabled const):
(WebCore::DocumentFullscreen::fullscreenElement const):
(WebCore::DocumentFullscreen::requestFullscreenForElement):
(WebCore::DocumentFullscreen::willEnterFullscreen):
(WebCore::DocumentFullscreen::elementEnterFullscreen):
(WebCore::DocumentFullscreen::didEnterFullscreen):
(WebCore::DocumentFullscreen::isSimpleFullscreenDocument const):
(WebCore::documentsToUnfullscreen):
(WebCore::clearFullscreenFlags):
(WebCore::DocumentFullscreen::exitFullscreen):
(WebCore::DocumentFullscreen::webkitExitFullscreen):
(WebCore::DocumentFullscreen::finishExitFullscreen):
(WebCore::DocumentFullscreen::willExitFullscreen):
(WebCore::DocumentFullscreen::didExitFullscreen):
(WebCore::DocumentFullscreen::exitRemovedFullscreenElement):
(WebCore::DocumentFullscreen::fullyExitFullscreen):
(WebCore::DocumentFullscreen::dispatchPendingEvents):
(WebCore::DocumentFullscreen::queueFullscreenChangeEventForDocument):
(WebCore::DocumentFullscreen::isAnimatingFullscreen const):
(WebCore::DocumentFullscreen::setAnimatingFullscreen):
(WebCore::DocumentFullscreen::logChannel const):
(WebCore::DocumentFullscreen::webkitFullscreenEnabled): Deleted.
(WebCore::DocumentFullscreen::webkitFullscreenElement): Deleted.
(WebCore::DocumentFullscreen::webkitIsFullScreen): Deleted.
(WebCore::DocumentFullscreen::webkitFullScreenKeyboardInputAllowed): Deleted.
(WebCore::DocumentFullscreen::webkitCurrentFullScreenElement): Deleted.
(WebCore::DocumentFullscreen::webkitCancelFullScreen): Deleted.
* Source/WebCore/dom/DocumentFullscreen.h:
* Source/WebCore/dom/DocumentOrShadowRootFullscreen.cpp:
(WebCore::DocumentOrShadowRootFullscreen::fullscreenElement):
* Source/WebCore/dom/Element.cpp:
(WebCore::Element::removedFromAncestor):
(WebCore::Element::requestFullscreen):
* Source/WebCore/dom/EventPath.cpp:
* Source/WebCore/dom/FullscreenManager.cpp: Removed.
* Source/WebCore/dom/FullscreenManager.h: Removed.
* Source/WebCore/html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::elementIsHidden const):
(WebCore::HTMLMediaElement::isFullscreen const):
(WebCore::HTMLMediaElement::isStandardFullscreen const):
(WebCore::HTMLMediaElement::enterFullscreen):
(WebCore::HTMLMediaElement::exitFullscreen):
* Source/WebCore/html/MediaElementSession.cpp:
(WebCore::MediaElementSession::canShowControlsManager const):
(WebCore::MediaElementSession::updateMediaUsageIfChanged):
* Source/WebCore/html/shadow/MediaControlTextTrackContainerElement.cpp:
* Source/WebCore/inspector/agents/InspectorDOMAgent.cpp:
* Source/WebCore/page/EventHandler.cpp:
(WebCore::EventHandler::isKeyEventAllowedInFullScreen const):
(WebCore::EventHandler::internalKeyEvent):
* Source/WebCore/page/LocalFrameView.cpp:
(WebCore::LocalFrameView::documentBackgroundColor const):
* Source/WebCore/page/Page.cpp:
(WebCore::Page::updateRendering):
(WebCore::Page::outermostFullscreenDocument const):
* Source/WebCore/page/ScreenOrientation.cpp:
(WebCore::ScreenOrientation::lock):
* Source/WebCore/page/ios/ContentChangeObserver.cpp:
(WebCore::isHiddenBehindFullscreenElement):
* Source/WebCore/rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::RenderLayerBacking):
* Source/WebCore/rendering/RenderLayerCompositor.cpp:
(WebCore::isDescendantOfFullScreenLayer):
* Source/WebCore/rendering/RenderVideo.cpp:
* Source/WebCore/style/StyleAdjuster.cpp:
(WebCore::Style::Adjuster::adjust const):
(WebCore::Style::Adjuster::adjustForSiteSpecificQuirks const):
* Source/WebCore/style/StyleSharingResolver.cpp:
* Source/WebCore/style/UserAgentStyle.cpp:
(WebCore::Style::UserAgentStyle::ensureDefaultStyleSheetsForElement):
* Source/WebCore/testing/Internals.cpp:
* Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp:
(WebKit::WebFullScreenManager::willEnterFullScreen):
(WebKit::WebFullScreenManager::willExitFullScreen):
(WebKit::collectFullscreenElementsFromElement):
(WebKit::WebFullScreenManager::setAnimatingFullScreen):
(WebKit::WebFullScreenManager::requestRestoreFullScreen):
(WebKit::WebFullScreenManager::requestExitFullScreen):
(WebKit::WebFullScreenManager::handleEvent):
(WebKit::WebFullScreenManager::mainVideoElementTextRecognitionTimerFired):
(WebKit::WebFullScreenManager::enterFullScreenForOwnerElements):
(WebKit::WebFullScreenManager::exitFullScreenInMainFrame):
* Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMDocumentGtk.cpp:
(webkit_dom_document_webkit_cancel_fullscreen):
(webkit_dom_document_webkit_exit_fullscreen):
(webkit_dom_document_get_webkit_is_fullscreen):
(webkit_dom_document_get_webkit_fullscreen_keyboard_input_allowed):
(webkit_dom_document_get_webkit_current_fullscreen_element):
(webkit_dom_document_get_webkit_fullscreen_enabled):
(webkit_dom_document_get_webkit_fullscreen_element):
* Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::createWindow):
* Source/WebKit/WebProcess/WebCoreSupport/WebLocalFrameLoaderClient.cpp:
(WebKit::WebLocalFrameLoaderClient::dispatchDidStartProvisionalLoad):
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::elementDidFocus):
* Source/WebKitLegacy/mac/DOM/DOMDocument.mm:
(-[DOMDocument webkitCurrentFullScreenElement]):
* Source/WebKitLegacy/mac/WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::createWindow):
* Source/WebKitLegacy/mac/WebCoreSupport/WebKitFullScreenListener.mm:
(-[WebKitFullScreenListener webkitWillEnterFullScreen]):
(-[WebKitFullScreenListener webkitWillExitFullScreen]):
* Source/WebKitLegacy/mac/WebView/WebFullScreenController.mm:
(-[WebFullScreenController requestExitFullScreen]):
(-[WebFullScreenController _manager]):
* Source/WebKitLegacy/mac/WebView/WebView.mm:
(-[WebView _didStartProvisionalLoadForFrame:]):

Canonical link: https://commits.webkit.org/291091@main

To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications