[webkit-changes] [WebKit/WebKit] 20a8cd: Fix PIP after 290788 at main

[Alex Christensen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 20a8cdcfa07d6c037cded0687ad8915b83b593b3
      https://github.com/WebKit/WebKit/commit/20a8cdcfa07d6c037cded0687ad8915b83b593b3
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2025-02-25 (Tue, 25 Feb 2025)

  Changed paths:
    M Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp

  Log Message:
  -----------
  Fix PIP after 290788 at main
https://bugs.webkit.org/show_bug.cgi?id=288451
rdar://145506817

Reviewed by Andy Estes.

290788 at main had a subtle and unintentional change in behavior.
In WebFullScreenManager::enterFullScreenForElement, if the mode
was VideoFullscreenModeInWindow, we used to call willEnterFullScreen
then immediately and unconditionally call didEnterFullScreen even
if the UI process did not send IPC indicating that the willEnterFullScreen
call succeeded.  This caused some subtle breakage with PIP, which doesn't
have great testability right now.  This PR effectively changes the behavior
back to how it was.  We still inform the UI process, but if it says that
willEnterFullScreen failed, we go anyways.

* Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp:
(WebKit::WebFullScreenManager::willEnterFullScreen):

Canonical link: https://commits.webkit.org/291030@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications