[webkit-changes] [WebKit/WebKit] 9a0b4a: Correct type and serialization of shadowRootCustom...

[Anne van Kesteren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9a0b4ad4f70ecb0194d1aa1a8fd172ba6f755b25
      https://github.com/WebKit/WebKit/commit/9a0b4ad4f70ecb0194d1aa1a8fd172ba6f755b25
  Author: Anne van Kesteren <annevk at annevk.nl>
  Date:   2025-02-25 (Tue, 25 Feb 2025)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/custom-elements/revamped-scoped-registry/ShadowRoot-init-customElements.tentative-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/custom-elements/revamped-scoped-registry/ShadowRoot-init-customElements.tentative.html
    A LayoutTests/imported/w3c/web-platform-tests/custom-elements/revamped-scoped-registry/template.tentative.window-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/custom-elements/revamped-scoped-registry/template.tentative.window.html
    A LayoutTests/imported/w3c/web-platform-tests/custom-elements/revamped-scoped-registry/template.tentative.window.js
    M LayoutTests/imported/w3c/web-platform-tests/custom-elements/revamped-scoped-registry/w3c-import.log
    M Source/WebCore/dom/ShadowRoot.idl
    M Source/WebCore/dom/ShadowRootInit.idl
    M Source/WebCore/editing/MarkupAccumulator.cpp
    M Source/WebCore/html/HTMLTemplateElement.idl

  Log Message:
  -----------
  Correct type and serialization of shadowRootCustomElements
https://bugs.webkit.org/show_bug.cgi?id=288364

Reviewed by Ryosuke Niwa.

The type of the IDL attribute is DOMString for forward compatibility,
according to the HTML PR, not boolean. Also add the missing
serialization logic.

* LayoutTests/imported/w3c/web-platform-tests/custom-elements/revamped-scoped-registry/ShadowRoot-init-customElements.tentative-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/custom-elements/revamped-scoped-registry/ShadowRoot-init-customElements.tentative.html:
* LayoutTests/imported/w3c/web-platform-tests/custom-elements/revamped-scoped-registry/template.tentative.window-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/custom-elements/revamped-scoped-registry/template.tentative.window.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/custom-elements/revamped-scoped-registry/template.tentative.window.js: Added.
(test):
* LayoutTests/imported/w3c/web-platform-tests/custom-elements/revamped-scoped-registry/w3c-import.log:
* Source/WebCore/dom/ShadowRoot.idl:

Clean up the member order while here and lead with the EnabledBySetting extended attribute.

* Source/WebCore/dom/ShadowRootInit.idl:

Remove an ignored "= null" for clarity. The added test passes either
way and is mainly there to ensure other implementations stay aligned.

* Source/WebCore/editing/MarkupAccumulator.cpp:
(WebCore::MarkupAccumulator::startAppendingNode):
* Source/WebCore/html/HTMLTemplateElement.idl:

Also lead with the EnabledBySetting extended attribute here.

Canonical link: https://commits.webkit.org/291015@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications