[webkit-changes] [WebKit/WebKit] 1ff950: [Site Isolation] Can’t go back after navigating a ...

[Charlie Wolfe]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1ff9501e4411edc4be61cbe88d1981d57a6cae46
      https://github.com/WebKit/WebKit/commit/1ff9501e4411edc4be61cbe88d1981d57a6cae46
  Author: Charlie Wolfe <charliew at apple.com>
  Date:   2025-02-24 (Mon, 24 Feb 2025)

  Changed paths:
    A LayoutTests/http/tests/site-isolation/history/navigate-same-site-iframe-into-new-process-and-go-back-expected.txt
    A LayoutTests/http/tests/site-isolation/history/navigate-same-site-iframe-into-new-process-and-go-back.html
    A LayoutTests/http/tests/site-isolation/history/resources/go-back.html
    M Source/WebKit/Shared/NavigationActionData.h
    M Source/WebKit/Shared/NavigationActionData.serialization.in
    M Source/WebKit/UIProcess/API/APINavigation.h
    M Source/WebKit/UIProcess/WebPageProxy.cpp
    M Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp
    M Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp
    M Source/WebKit/WebProcess/WebCoreSupport/WebLocalFrameLoaderClient.cpp

  Log Message:
  -----------
  [Site Isolation] Can’t go back after navigating a same-site iframe into a new process
https://bugs.webkit.org/show_bug.cgi?id=288393
rdar://138924071

Reviewed by Alex Christensen.

The condition in WebPageProxy::continueNavigationInNewProcess was incorrect; it should be true only for
the first load of a child frame but could have been true when a same-site iframe was navigated
cross-site.

* LayoutTests/http/tests/site-isolation/history/navigate-same-site-iframe-into-new-process-and-go-back-expected.txt: Added.
* LayoutTests/http/tests/site-isolation/history/navigate-same-site-iframe-into-new-process-and-go-back.html: Added.
* LayoutTests/http/tests/site-isolation/history/resources/go-back.html: Added.
* Source/WebKit/Shared/NavigationActionData.h:
* Source/WebKit/Shared/NavigationActionData.serialization.in:
* Source/WebKit/UIProcess/API/APINavigation.h:
(API::Navigation::isInitialFrameSrcLoad const):
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::continueNavigationInNewProcess):
* Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::createWindow):
* Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::navigationActionData const):
* Source/WebKit/WebProcess/WebCoreSupport/WebLocalFrameLoaderClient.cpp:
(WebKit::WebLocalFrameLoaderClient::didSameDocumentNavigationForFrameViaJS):
(WebKit::WebLocalFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):

Canonical link: https://commits.webkit.org/290988@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications