[webkit-changes] [WebKit/WebKit] a93a85: Revert "Document Leak Occurs when opening Context ...

[Nathan Solomon]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a93a850d95abeff529f1c0fac4bb23d60db9508c
      https://github.com/WebKit/WebKit/commit/a93a850d95abeff529f1c0fac4bb23d60db9508c
  Author: Nathan Solomon <nathan_solomon at apple.com>
  Date:   2025-02-24 (Mon, 24 Feb 2025)

  Changed paths:
    R LayoutTests/editing/mac/spelling/disable-automatic-spelling-correction-context-menu-item-does-not-leak-expected.txt
    R LayoutTests/editing/mac/spelling/disable-automatic-spelling-correction-context-menu-item-does-not-leak.html
    M LayoutTests/editing/mac/spelling/disable-automatic-spelling-correction-context-menu-item.html
    M LayoutTests/platform/mac-wk1/TestExpectations
    M LayoutTests/resources/document-leak-test.js
    M Source/WebCore/page/ContextMenuController.cpp
    M Source/WebCore/page/ContextMenuController.h
    M Source/WebCore/testing/Internals.cpp
    M Source/WebKit/UIProcess/WebPageProxy.cpp

  Log Message:
  -----------
  Revert "Document Leak Occurs when opening Context Menu"

This reverts commit a6ce7b296295f0b388d6c7ea235bdc2490d13508.

rdar://144376351
https://bugs.webkit.org/show_bug.cgi?id=288389

Reviewed by Ryan Reno.

Reverting this document leak fix because we think that this change is likely causing a nullptr dereference crash in certain cases
where a Ref to a Node (contained in the Context Menu state) has been cleared after dismissing the context menu but the
user still needs to select an item from the context menu item. The Node is then accessed while its null.

Combined changes:
* LayoutTests/editing/mac/spelling/disable-automatic-spelling-correction-context-menu-item-does-not-leak-expected.txt: Removed.
* LayoutTests/editing/mac/spelling/disable-automatic-spelling-correction-context-menu-item-does-not-leak.html: Removed.
* LayoutTests/editing/mac/spelling/disable-automatic-spelling-correction-context-menu-item.html:
* LayoutTests/platform/mac-wk1/TestExpectations:
* LayoutTests/resources/document-leak-test.js:
(runDocumentLeakTest):
(async runDocumentLeakTestSynchronously): Deleted.
(cleanIframeUponMessageReceived): Deleted.
* Source/WebCore/page/ContextMenuController.cpp:
(WebCore::ContextMenuController::didDismissContextMenu):
* Source/WebCore/page/ContextMenuController.h:
(WebCore::ContextMenuController::setContextMenuContext):
* Source/WebCore/testing/Internals.cpp:
(WebCore::Internals::resetToConsistentState):
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didDismissContextMenu):

Canonical link: https://commits.webkit.org/290980@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications