[webkit-changes] [WebKit/WebKit] 0ee109: Unreviewed, re-landing 290928 at main

[geoffreygaren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0ee109c50d1f7066d48f5957e0b644dad2092a92
      https://github.com/WebKit/WebKit/commit/0ee109c50d1f7066d48f5957e0b644dad2092a92
  Author: Geoffrey Garen <ggaren at apple.com>
  Date:   2025-02-24 (Mon, 24 Feb 2025)

  Changed paths:
    M Source/WTF/wtf/RetainPtr.h
    M Source/WTF/wtf/cocoa/TypeCastsCocoa.h
    M Source/WebCore/bridge/objc/objc_runtime.h
    M Source/WebCore/platform/PlatformSpeechSynthesisUtterance.h
    M Source/WebCore/platform/network/cf/AuthenticationChallenge.h
    M Tools/DumpRenderTree/AccessibilityUIElement.cpp
    M Tools/DumpRenderTree/AccessibilityUIElement.h
    M Tools/DumpRenderTree/ios/AccessibilityUIElementIOS.mm
    M Tools/DumpRenderTree/mac/AccessibilityTextMarkerMac.mm
    M Tools/DumpRenderTree/mac/AccessibilityUIElementMac.mm
    M Tools/TestWebKitAPI/Tests/WTF/cocoa/TypeCastsCocoa.mm
    M Tools/TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm
    M Tools/WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.cpp
    M Tools/WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.h
    M Tools/WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.cpp
    M Tools/WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.h

  Log Message:
  -----------
  Unreviewed, re-landing 290928 at main
https://bugs.webkit.org/show_bug.cgi?id=288379
rdar://145490867

Fixed the Safari build.

Re-landed changeset:

"RetainPtr’s leakRef() and move constructors are incorrect when ARC is enabled"

* Source/WTF/wtf/RetainPtr.h:
(WTF::RetainPtr::RetainPtr):
(WTF::RetainPtr::isHashTableDeletedValue const):
(WTF::RetainPtr::get const):
(WTF::RetainPtr::operator-> const):
(WTF::RetainPtr::operator PtrType const):
(WTF::RetainPtr::hashTableDeletedValue):
(WTF::RetainPtr::retainFoundationPtr):
(WTF::RetainPtr::releaseFoundationPtr):
(WTF::RetainPtr::autoreleaseFoundationPtr):
(WTF::RetainPtr<T>::~RetainPtr):
(WTF::RetainPtr<T>::RetainPtr):
(WTF::RetainPtr<T>::clear):
(WTF::RetainPtr<T>::autorelease):
(WTF::adoptCF):
(WTF::adoptNS):
(WTF::RetainPtr::checkType): Deleted.
(WTF::RetainPtr::fromStorageTypeHelper): Deleted.
(WTF::RetainPtr::fromStorageType): Deleted.
(WTF::RetainPtr::toStorageType): Deleted.
* Source/WTF/wtf/cocoa/TypeCastsCocoa.h:
* Source/WebCore/bridge/objc/objc_runtime.h:
* Source/WebCore/platform/PlatformSpeechSynthesisUtterance.h:
* Source/WebCore/platform/network/cf/AuthenticationChallenge.h:
* Tools/DumpRenderTree/AccessibilityUIElement.cpp:
(getIsValidCallback):
(AccessibilityUIElement::makeJSAccessibilityUIElement):
(AccessibilityUIElement::isEqual): Deleted.
* Tools/DumpRenderTree/AccessibilityUIElement.h:
(AccessibilityUIElement::hasPlatformUIElement const):
* Tools/DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
(AccessibilityUIElement::isEqual):
* Tools/DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
(AccessibilityTextMarker::AccessibilityTextMarker):
* Tools/DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::isEqual):
* Tools/TestWebKitAPI/Tests/WTF/cocoa/TypeCastsCocoa.mm:
(TestWebKitAPI::TEST(TypeCastsCocoa, bridge_cast)):
* Tools/TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
(TestWebKitAPI::TEST(RETAIN_PTR_TEST_NAME, ConstructionFromMutableNSType)):
(TestWebKitAPI::TEST(RETAIN_PTR_TEST_NAME, ConstructionFromSimilarNSType)):
(TestWebKitAPI::TEST(RETAIN_PTR_TEST_NAME, ConstructionFromSimilarNSTypeReversed)):
(TestWebKitAPI::TEST(RETAIN_PTR_TEST_NAME, MoveAssignmentFromSimilarNSType)):
(TestWebKitAPI::TEST(RETAIN_PTR_TEST_NAME, MoveAssignmentFromSimilarNSTypeReversed)):
(TestWebKitAPI::TEST(RETAIN_PTR_TEST_NAME, BridgingAutorelease)):
(TestWebKitAPI::TEST(RETAIN_PTR_TEST_NAME, URLBridgeCast)):
(TestWebKitAPI::TEST(RETAIN_PTR_TEST_NAME, HashMapCFTypeDeletedValue)):
* Tools/WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.cpp:
(WTR::AccessibilityTextMarker::AccessibilityTextMarker):
(WTR::AccessibilityTextMarker::platformTextMarker const): Deleted.
* Tools/WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.h:
(WTR::AccessibilityTextMarker::platformTextMarker const):
* Tools/WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.cpp:
(WTR::AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
(WTR::AccessibilityTextMarkerRange::platformTextMarkerRange const): Deleted.
* Tools/WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.h:
(WTR::AccessibilityTextMarkerRange::platformTextMarkerRange const):

Canonical link: https://commits.webkit.org/290967@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications