[webkit-changes] [WebKit/WebKit] 734c49: Fix flaky crash in ResourceMonitor.

Basuke Suzuki noreply at github.com
Mon Feb 24 09:02:14 PST 2025


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 734c49b3d075dcc33f56becf3bde8aca5245b719
      https://github.com/WebKit/WebKit/commit/734c49b3d075dcc33f56becf3bde8aca5245b719
  Author: Basuke Suzuki <basuke at apple.com>
  Date:   2025-02-24 (Mon, 24 Feb 2025)

  Changed paths:
    M Source/WebCore/loader/ResourceMonitor.cpp
    M Source/WebCore/loader/ResourceMonitorChecker.cpp

  Log Message:
  -----------
  Fix flaky crash in ResourceMonitor.
https://bugs.webkit.org/show_bug.cgi?id=288357
rdar://145427232

Reviewed by Chris Dumez.

In ResourceMonitor.cpp, a macro to produce RELEASE_LOG is defined and m_frame weak ptr is used without checking.

Add check before calling that macro.

* Source/WebCore/loader/ResourceMonitor.cpp:
(WebCore::ResourceMonitor::setEligibility):
(WebCore::ResourceMonitor::addNetworkUsage):
(WebCore::ResourceMonitor::updateNetworkUsageThreshold):
* Source/WebCore/loader/ResourceMonitorChecker.cpp:
(WebCore::ResourceMonitorChecker::setNetworkUsageThreshold):

Canonical link: https://commits.webkit.org/290954@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list