[webkit-changes] [WebKit/WebKit] e40b0d: [ANGLE] Workaround ASan false-positive stack-use-a...

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e40b0da91f79998db53271c8a9ad3740b9dfe23f
      https://github.com/WebKit/WebKit/commit/e40b0da91f79998db53271c8a9ad3740b9dfe23f
  Author: David Kilzer <ddkilzer at apple.com>
  Date:   2025-02-24 (Mon, 24 Feb 2025)

  Changed paths:
    M Configurations/Sanitizers.xcconfig
    M Configurations/WebKitTargetConditionals.xcconfig
    M Source/ThirdParty/ANGLE/src/compiler/translator/InfoSink.h

  Log Message:
  -----------
  [ANGLE] Workaround ASan false-positive stack-use-after-scope in Xcode 16.3
<https://bugs.webkit.org/show_bug.cgi?id=288308>
<rdar://144259986>

Reviewed by John Wilander and Kimmo Kinnunen.

* Configurations/Sanitizers.xcconfig:
(WK_ADDRESS_SANITIZER_OTHER_CFLAGS_YES):
(WK_NEEDS_RDAR_145268301_ASAN_STACK_USE_AFTER_SCOPE_WORKAROUND): Add.
(WK_WORKAROUND_RDAR_145268301_ASAN_STACK_USE_AFTER_SCOPE): Add.
(WK_WORKAROUND_RDAR_145268301_ASAN_STACK_USE_AFTER_SCOPE_YES): Add.
- Include a command-line switch to define a macro if the workaround is
  needed.
* Configurations/WebKitTargetConditionals.xcconfig:
(WK_XCODE_BEFORE_16_3): Add.
(WK_XCODE_BEFORE_16_3_XCODE_BEFORE_16): Add.
(WK_XCODE_BEFORE_16_3_XCODE_SINCE_16): Add.
(WK_XCODE_BEFORE_16_3_1600): Add.
(WK_XCODE_BEFORE_16_3_1610): Add.
(WK_XCODE_BEFORE_16_3_1620): Add.
(WK_XCODE_16_3): Add.
(WK_XCODE_16_3_): Add.
(WK_XCODE_16_3_YES): Add.
- Add version checking variables for Xcode 16.3.
* Source/ThirdParty/ANGLE/src/compiler/translator/InfoSink.h:
(sh::fractionalPart):
- Disable ASan if the workaround is needed.

Canonical link: https://commits.webkit.org/290943@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications