[webkit-changes] [WebKit/WebKit] 894f76: [Site Isolation] Propagate mute and volume state t...

[bnham]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 894f7621ad561152153a588951cbed7f6069769e
      https://github.com/WebKit/WebKit/commit/894f7621ad561152153a588951cbed7f6069769e
  Author: Ben Nham <nham at apple.com>
  Date:   2025-02-23 (Sun, 23 Feb 2025)

  Changed paths:
    M Source/WebCore/testing/Internals.cpp
    M Source/WebCore/testing/Internals.h
    M Source/WebCore/testing/Internals.idl
    M Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivateForTesting.h
    M Source/WebKit/UIProcess/API/Cocoa/WKWebViewTesting.mm
    M Source/WebKit/UIProcess/WebPageProxy.cpp
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm

  Log Message:
  -----------
  [Site Isolation] Propagate mute and volume state to remote frames
https://bugs.webkit.org/show_bug.cgi?id=288136
rdar://145241258

Reviewed by Eric Carlson.

There are a number of media-related WebPageProxy methods which only forward state changes to the
main frame and not to out of process iframes. In this patch we forward mute and volume state changes
to OOP iframes. Previously we were only propagating those state changes to the main frame's process.

* Source/WebCore/testing/Internals.cpp:
(WebCore::Internals::pageMediaVolume):
* Source/WebCore/testing/Internals.h:
* Source/WebCore/testing/Internals.idl:
* Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivateForTesting.h:
* Source/WebKit/UIProcess/API/Cocoa/WKWebViewTesting.mm:
(-[WKWebView _setMediaVolumeForTesting:]):
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::setMediaVolume):
(WebKit::WebPageProxy::setMuted):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm:
(TestWebKitAPI::TEST(SiteIsolation, MutesAndSetsAudioInMultipleFrames)):

Canonical link: https://commits.webkit.org/290910@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications