[webkit-changes] [WebKit/WebKit] 1b9a20: AX: With ENABLE(INCLUDE_IGNORED_IN_CORE_AX_TREE) w...

[Tyler Wilcock]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1b9a2025ca119638448bfa4fc1e3b7875a1d4a81
      https://github.com/WebKit/WebKit/commit/1b9a2025ca119638448bfa4fc1e3b7875a1d4a81
  Author: Tyler Wilcock <tyler_w at apple.com>
  Date:   2025-02-23 (Sun, 23 Feb 2025)

  Changed paths:
    M LayoutTests/accessibility/details-summary-content-hidden.html
    M Source/WebCore/accessibility/AXObjectCache.cpp
    M Source/WebCore/accessibility/AXObjectCache.h
    M Source/WebCore/accessibility/AccessibilityRenderObject.cpp
    M Source/WebCore/dom/SlotAssignment.cpp
    M Source/WebCore/html/HTMLSlotElement.cpp
    M Source/WebCore/html/HTMLSlotElement.h

  Log Message:
  -----------
  AX: With ENABLE(INCLUDE_IGNORED_IN_CORE_AX_TREE) we need to eagerly recompute is-ignored for descendants of aria-hidden elements
https://bugs.webkit.org/show_bug.cgi?id=288299
rdar://145387158

Reviewed by Chris Fleizach.

Prior to ENABLE(INCLUDE_IGNORED_IN_CORE_AX_TREE), we handled dynamic aria-hidden changes with AXObjectCache::childrenChanged.
However, with ENABLE(INCLUDE_IGNORED_IN_CORE_AX_TREE), there are no actual accessibility tree changes, just different
is-ignored values for the subtree. This fixes these two tests:

  - accessibility/aria-hidden-updates-alldescendants.html
  - accessibility/mac/iframe-aria-hidden.html

This commit also fixes an existing bug exposed by ENABLE(INCLUDE_IGNORED_IN_CORE_AX_TREE) where we don't process
childrenChanged events when the elements filling a slot change, which impacts the accessibility tree. This fixes
accessibility/mac/invalid-summary-element.html.

Finally, we fix accessibility/details-summary-content-hidden.html by making the test more async.

* LayoutTests/accessibility/details-summary-content-hidden.html:
* Source/WebCore/accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::onSlottedContentChange):
(WebCore::AXObjectCache::handleAttributeChange):
* Source/WebCore/accessibility/AXObjectCache.h:
* Source/WebCore/accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::addNodeOnlyChildren):
* Source/WebCore/dom/SlotAssignment.cpp:
(WebCore::NamedSlotAssignment::didChangeSlot):
* Source/WebCore/html/HTMLSlotElement.cpp:
(WebCore::HTMLSlotElement::updateAccessibilityOnSlotChange const):
* Source/WebCore/html/HTMLSlotElement.h:

Canonical link: https://commits.webkit.org/290908@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications