[webkit-changes] [WebKit/WebKit] 0dc82e: AX: AccessibilityRenderObject::addChildren() somet...

[Tyler Wilcock]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0dc82e8cdc0995ab208f7cd970a9328fd39c0594
      https://github.com/WebKit/WebKit/commit/0dc82e8cdc0995ab208f7cd970a9328fd39c0594
  Author: Tyler Wilcock <tyler_w at apple.com>
  Date:   2025-02-22 (Sat, 22 Feb 2025)

  Changed paths:
    M Source/WebCore/accessibility/AccessibilityRenderObject.cpp

  Log Message:
  -----------
  AX: AccessibilityRenderObject::addChildren() sometimes does not null-check the AXObjectCache before using it, causing crashes
https://bugs.webkit.org/show_bug.cgi?id=288238
rdar://145319178

Reviewed by Chris Fleizach.

I see some rare crashes in accessibility/add-children-pseudo-element.html and other tests because we aren't null-checking
the cache before using it. This commit adds the appropriate checks.

* Source/WebCore/accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::addChildren):

Canonical link: https://commits.webkit.org/290903@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications