[webkit-changes] [WebKit/WebKit] 92ab86: REGRESSION(288357 at main): Crash in `WebHistoryItemC...

[Charlie Wolfe]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 92ab86c96733339731d0c2abfeec831624851035
      https://github.com/WebKit/WebKit/commit/92ab86c96733339731d0c2abfeec831624851035
  Author: Charlie Wolfe <charliew at apple.com>
  Date:   2025-02-22 (Sat, 22 Feb 2025)

  Changed paths:
    M Source/WebKit/WebProcess/WebPage/WebHistoryItemClient.cpp
    M Source/WebKit/WebProcess/WebPage/WebHistoryItemClient.h

  Log Message:
  -----------
  REGRESSION(288357 at main): Crash in `WebHistoryItemClient::historyItemChanged`
https://bugs.webkit.org/show_bug.cgi?id=288279
rdar://142947060

Reviewed by Alex Christensen.

WebHistoryItemClient can outlive its WebPage, so it should hold a WeakPtr to WebPage instead of a
WeakRef.

* Source/WebKit/WebProcess/WebPage/WebHistoryItemClient.cpp:
(WebKit::WebHistoryItemClient::historyItemChanged):
(WebKit::WebHistoryItemClient::clearChildren const):
* Source/WebKit/WebProcess/WebPage/WebHistoryItemClient.h:

Canonical link: https://commits.webkit.org/290892@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications