[webkit-changes] [WebKit/WebKit] 17169d: Update RobinhoodHashTable to validate its key in r...

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 17169d32e21511adf937e578e812e76f574500c1
      https://github.com/WebKit/WebKit/commit/17169d32e21511adf937e578e812e76f574500c1
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2025-02-22 (Sat, 22 Feb 2025)

  Changed paths:
    M Source/JavaScriptCore/runtime/CachedTypes.cpp
    M Source/WTF/wtf/RobinHoodHashMap.h
    M Source/WTF/wtf/RobinHoodHashTable.h

  Log Message:
  -----------
  Update RobinhoodHashTable to validate its key in release builds
https://bugs.webkit.org/show_bug.cgi?id=288207

Reviewed by Ryosuke Niwa.

Update RobinhoodHashTable to validate its key in release builds, as security hardening.

* Source/JavaScriptCore/runtime/CachedTypes.cpp:
(JSC::CachedHashMap::encode):
(JSC::CachedHashMap::decode const):
* Source/WTF/wtf/RobinHoodHashMap.h:
* Source/WTF/wtf/RobinHoodHashTable.h:
(WTF::shouldValidateKey>::checkKey):
(WTF::shouldValidateKey>::lookup):
(WTF::shouldValidateKey>::inlineLookup):
(WTF::shouldValidateKey>::initializeBucket):
(WTF::shouldValidateKey>::add):
(WTF::shouldValidateKey>::maintainProbeDistanceForAdd):
(WTF::shouldValidateKey>::addPassingHashCode):
(WTF::shouldValidateKey>::reinsert):
(WTF::shouldValidateKey>::find):
(WTF::shouldValidateKey>::find const):
(WTF::shouldValidateKey>::contains const):
(WTF::shouldValidateKey>::removeAndInvalidateWithoutEntryConsistencyCheck):
(WTF::shouldValidateKey>::removeAndInvalidate):
(WTF::shouldValidateKey>::remove):
(WTF::shouldValidateKey>::removeWithoutEntryConsistencyCheck):
(WTF::shouldValidateKey>::allocateTable):
(WTF::shouldValidateKey>::deallocateTable):
(WTF::shouldValidateKey>::expand):
(WTF::shouldValidateKey>::computeBestTableSize):
(WTF::shouldValidateKey>::shrinkToBestSize):
(WTF::shouldValidateKey>::rehash):
(WTF::shouldValidateKey>::clear):
(WTF::shouldValidateKey>::RobinHoodHashTable):
(WTF::shouldValidateKey>::swap):
(WTF::=):
(WTF::shouldValidateKey>::checkTableConsistency const):
(WTF::shouldValidateKey>::checkTableConsistencyExceptSize const):
(WTF::SizePolicy>::checkKey): Deleted.
(WTF::SizePolicy>::lookup): Deleted.
(WTF::SizePolicy>::inlineLookup): Deleted.
(WTF::SizePolicy>::initializeBucket): Deleted.
(WTF::SizePolicy>::add): Deleted.
(WTF::SizePolicy>::maintainProbeDistanceForAdd): Deleted.
(WTF::SizePolicy>::addPassingHashCode): Deleted.
(WTF::SizePolicy>::reinsert): Deleted.
(WTF::SizePolicy>::find): Deleted.
(WTF::SizePolicy>::find const): Deleted.
(WTF::SizePolicy>::contains const): Deleted.
(WTF::SizePolicy>::removeAndInvalidateWithoutEntryConsistencyCheck): Deleted.
(WTF::SizePolicy>::removeAndInvalidate): Deleted.
(WTF::SizePolicy>::remove): Deleted.
(WTF::SizePolicy>::removeWithoutEntryConsistencyCheck): Deleted.
(WTF::SizePolicy>::allocateTable): Deleted.
(WTF::SizePolicy>::deallocateTable): Deleted.
(WTF::SizePolicy>::expand): Deleted.
(WTF::SizePolicy>::computeBestTableSize): Deleted.
(WTF::SizePolicy>::shrinkToBestSize): Deleted.
(WTF::SizePolicy>::rehash): Deleted.
(WTF::SizePolicy>::clear): Deleted.
(WTF::SizePolicy>::RobinHoodHashTable): Deleted.
(WTF::SizePolicy>::swap): Deleted.
(WTF::SizePolicy>::checkTableConsistency const): Deleted.
(WTF::SizePolicy>::checkTableConsistencyExceptSize const): Deleted.

Canonical link: https://commits.webkit.org/290890@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications