[webkit-changes] [WebKit/WebKit] 0bcdd2: Rename `cancelFullscreen` to `fullyExitFullscreen`...

[Tim Nguyen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0bcdd2231ae8852bfa95de0310c9931c44746ed3
      https://github.com/WebKit/WebKit/commit/0bcdd2231ae8852bfa95de0310c9931c44746ed3
  Author: Tim Nguyen <ntim at apple.com>
  Date:   2025-02-22 (Sat, 22 Feb 2025)

  Changed paths:
    M Source/WebCore/dom/DocumentFullscreen.cpp
    M Source/WebCore/dom/FullscreenManager.cpp
    M Source/WebCore/dom/FullscreenManager.h
    M Source/WebCore/html/HTMLMediaElement.cpp
    M Source/WebCore/page/EventHandler.cpp
    M Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp
    M Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMDocumentGtk.cpp
    M Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp
    M Source/WebKit/WebProcess/WebPage/WebPage.cpp
    M Source/WebKitLegacy/mac/WebCoreSupport/WebChromeClient.mm
    M Source/WebKitLegacy/mac/WebView/WebFullScreenController.mm

  Log Message:
  -----------
  Rename `cancelFullscreen` to `fullyExitFullscreen` in `FullscreenManager`
https://bugs.webkit.org/show_bug.cgi?id=288286
rdar://145374210

Reviewed by Simon Fraser.

Match terminology in the spec, which is more descriptive than "cancel fullscreen".

https://fullscreen.spec.whatwg.org/#fully-exit-fullscreen

* Source/WebCore/dom/DocumentFullscreen.cpp:
(WebCore::DocumentFullscreen::webkitCancelFullScreen):
* Source/WebCore/dom/FullscreenManager.cpp:
(WebCore::FullscreenManager::fullyExitFullscreen):
(WebCore::FullscreenManager::cancelFullscreen): Deleted.
* Source/WebCore/dom/FullscreenManager.h:
* Source/WebCore/html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::exitFullscreen):
* Source/WebCore/page/EventHandler.cpp:
(WebCore::EventHandler::internalKeyEvent):
* Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp:
(WebKit::WebFullScreenManager::requestExitFullScreen):
* Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMDocumentGtk.cpp:
(webkit_dom_document_webkit_cancel_fullscreen):
* Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::createWindow):
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::elementDidFocus):
* Source/WebKitLegacy/mac/WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::createWindow):
* Source/WebKitLegacy/mac/WebView/WebFullScreenController.mm:
(-[WebFullScreenController requestExitFullScreen]):

Canonical link: https://commits.webkit.org/290883@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications