[webkit-changes] [WebKit/WebKit] 94c637: Some RetainPtr cleanup

[geoffreygaren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 94c637751ff29d9b2bb055edcde12ec71ea24f50
      https://github.com/WebKit/WebKit/commit/94c637751ff29d9b2bb055edcde12ec71ea24f50
  Author: Geoffrey Garen <ggaren at apple.com>
  Date:   2025-02-22 (Sat, 22 Feb 2025)

  Changed paths:
    M Source/WTF/wtf/RetainPtr.h
    M Source/WebCore/editing/cocoa/WebCoreTextAttachment.mm
    M Source/WebCore/platform/cf/RunLoopObserverCF.cpp
    M Source/WebCore/platform/cocoa/ContentFilterUnblockHandlerCocoa.mm
    M Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVContentKeySession.h
    M Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVContentKeySession.mm
    M Source/WebCore/platform/graphics/cocoa/GraphicsContextGLCocoa.mm
    M Source/WebCore/platform/graphics/cocoa/UnrealizedCoreTextFont.cpp
    M Source/WebCore/platform/ios/wak/WebCoreThread.mm
    M Source/WebCore/platform/text/cf/HyphenationCF.cpp
    M Source/WebKit/Shared/Cocoa/ArgumentCodersCocoa.mm
    M Source/WebKit/UIProcess/ios/WKActionSheetAssistant.mm
    M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
    M Source/WebKit/UIProcess/mac/CorrectionPanel.h
    M Source/WebKit/UIProcess/mac/WebPageProxyMac.mm
    M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm
    M Source/WebKitLegacy/mac/WebCoreSupport/CorrectionPanel.h
    M Source/WebKitLegacy/mac/WebView/WebHTMLView.mm
    M Source/WebKitLegacy/mac/WebView/WebView.mm
    M Tools/TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm
    M Tools/TestWebKitAPI/Tests/WebCore/cg/GraphicsContextCGTests.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm

  Log Message:
  -----------
  Some RetainPtr cleanup
https://bugs.webkit.org/show_bug.cgi?id=288269
<rdar://problem/145371472>

Reviewed by Ryosuke Niwa.

Removed implicit conversion to pointer, which was an old-school not 100%
type-safe way to do boolean tests.

Updated call sites to convert to boolean or load a pointer explicitly.

Added autorelease pools so that the OptionalRetainPtrNS API test passes in
debug builds with ARC, even though ARC autoreleases all intermediate pointers.

Added a test for leakRef() in ARC. This test currently fails (!!), so it's
disabled for now.

* Source/WTF/wtf/RetainPtr.h:
(WTF::RetainPtr::operator UnspecifiedBoolType const): Deleted.
* Source/WebCore/editing/cocoa/WebCoreTextAttachment.mm:
(WebCore::webCoreTextAttachmentMissingPlatformImage):
* Source/WebCore/platform/cf/RunLoopObserverCF.cpp:
(WebCore::RunLoopObserver::isScheduled const):
* Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVContentKeySession.h:
(WebCore::CDMSessionAVContentKeySession::hasContentKeySession const):
* Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVContentKeySession.mm:
(WebCore::CDMSessionAVContentKeySession::update):
(WebCore::CDMSessionAVContentKeySession::hasContentKeyRequest const):
* Source/WebCore/platform/graphics/cocoa/UnrealizedCoreTextFont.cpp:
(WebCore::UnrealizedCoreTextFont::operator bool const):
* Source/WebCore/platform/text/cf/HyphenationCF.cpp:
(WebCore::canHyphenate):
* Source/WebKit/Shared/Cocoa/ArgumentCodersCocoa.mm:
(IPC::isSerializableFont):
* Source/WebKit/UIProcess/mac/CorrectionPanel.h:
(WebKit::CorrectionPanel::isShowing const):
* Source/WebKit/UIProcess/mac/WebPageProxyMac.mm:
(WebKit::temporaryPDFDirectoryPath):
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm:
(WebKit::UnifiedPDFPlugin::isEditingCommandEnabled):
* Source/WebKitLegacy/mac/WebCoreSupport/CorrectionPanel.h:
(CorrectionPanel::isShowing const):
* Source/WebKitLegacy/mac/WebView/WebHTMLView.mm:
(-[WebHTMLView _plainTextFromPasteboard:]):
(-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):
(-[WebHTMLView _fontAttributesFromFontPasteboard]):
* Tools/TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
(TestWebKitAPI::TEST(RETAIN_PTR_TEST_NAME, OptionalRetainPtrNS)):
* Tools/TestWebKitAPI/Tests/WebCore/cg/GraphicsContextCGTests.mm:
(TestWebKitAPI::TEST(GraphicsContextTests, CGBitmapRenderingModeIsUnaccelerated)):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
(LoadInfo)):

Canonical link: https://commits.webkit.org/290875@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications