[webkit-changes] [WebKit/WebKit] 37a5e7: [UnifiedPDF] [iOS] PDFs are painted into enormous ...

[Tim Horton]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 37a5e784e903f16752ea18649206a70e70f9d611
      https://github.com/WebKit/WebKit/commit/37a5e784e903f16752ea18649206a70e70f9d611
  Author: Tim Horton <thorton at apple.com>
  Date:   2025-02-21 (Fri, 21 Feb 2025)

  Changed paths:
    M Source/WebCore/page/LocalFrameView.h
    M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm

  Log Message:
  -----------
  [UnifiedPDF] [iOS] PDFs are painted into enormous tiles
https://bugs.webkit.org/show_bug.cgi?id=288281

Reviewed by Abrar Rahman Protyasha.

288932 at main changed UnifiedPDFPlugin on iOS to expand the plugin to the size
of the PDF document. This made the plugin's internal ScrollableArea's
`allows{Vertical,Horizontal}Scrolling` always return NO. This resulted in
computeScrollability() returning `NotScrollable`, which, once plumbed to
TileController, resulted in us trying to allocate absolutely enormous tiles
(I managed to get 2048x8192 tiles on iPad).

If we're in `shouldSizeToFitContent` mode, delegate computeScrollability() to
the parent frame's scroller to fix this.

* Source/WebCore/page/LocalFrameView.h:
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm:
(WebKit::UnifiedPDFPlugin::computeScrollability const):

Canonical link: https://commits.webkit.org/290865@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications