[webkit-changes] [WebKit/WebKit] 13b9f7: Remove `m_fullscreenElement` from `FullscreenManager`

Tim Nguyen noreply at github.com
Fri Feb 21 23:07:00 PST 2025


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 13b9f7bb190fdf3927349d552cd510b271761eaf
      https://github.com/WebKit/WebKit/commit/13b9f7bb190fdf3927349d552cd510b271761eaf
  Author: Tim Nguyen <ntim at apple.com>
  Date:   2025-02-21 (Fri, 21 Feb 2025)

  Changed paths:
    M Source/WebCore/dom/Document.cpp
    M Source/WebCore/dom/FullscreenManager.cpp
    M Source/WebCore/dom/FullscreenManager.h

  Log Message:
  -----------
  Remove `m_fullscreenElement` from `FullscreenManager`
https://bugs.webkit.org/show_bug.cgi?id=288278
rdar://145344931

Reviewed by Alex Christensen.

Use `fullscreenElement()` instead of storing the element as a member.

* Source/WebCore/dom/Document.cpp:
(WebCore::Document::removedLastRef):
* Source/WebCore/dom/FullscreenManager.cpp:
(WebCore::FullscreenManager::willEnterFullscreen):
(WebCore::FullscreenManager::willExitFullscreen):
(WebCore::FullscreenManager::didExitFullscreen):
(WebCore::FullscreenManager::clear): Deleted.
* Source/WebCore/dom/FullscreenManager.h:

Canonical link: https://commits.webkit.org/290863@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list