[webkit-changes] [WebKit/WebKit] a3dded: Always call completion handlers in FullscreenManag...

[Alex Christensen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a3dded6670b8b8cfda8658107a6dc97e6754753c
      https://github.com/WebKit/WebKit/commit/a3dded6670b8b8cfda8658107a6dc97e6754753c
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2025-02-21 (Fri, 21 Feb 2025)

  Changed paths:
    M Source/WebCore/dom/FullscreenManager.cpp

  Log Message:
  -----------
  Always call completion handlers in FullscreenManager::exitFullscreen
https://bugs.webkit.org/show_bug.cgi?id=288276
rdar://145343638

Reviewed by Tim Nguyen.

I made a mistake, resulting in timing-dependent assertions when run loops terminate.
This introduces CompletionHandlerScope to call the CompletionHandler if it goes out
of scope when the queueTask call is never queued.

* Source/WebCore/dom/FullscreenManager.cpp:
(WebCore::FullscreenManager::exitFullscreen):

Canonical link: https://commits.webkit.org/290859@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications