[webkit-changes] [WebKit/WebKit] 6a1bea: Fix TestWebKitAPI.WKDownload.DownloadRequestFailur...
Alex Christensen
noreply at github.com
Fri Feb 21 21:34:43 PST 2025
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 6a1bea9490ae15e546b0caaf83ba65857c88da05
https://github.com/WebKit/WebKit/commit/6a1bea9490ae15e546b0caaf83ba65857c88da05
Author: Alex Christensen <achristensen at apple.com>
Date: 2025-02-21 (Fri, 21 Feb 2025)
Changed paths:
M Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm
Log Message:
-----------
Fix TestWebKitAPI.WKDownload.DownloadRequestFailure after 289946 at main
https://bugs.webkit.org/show_bug.cgi?id=288259
rdar://145330588
Reviewed by Ryosuke Niwa.
"ftp:///" is a URL that NSURL thinks is valid but WTF::URL thinks is invalid.
Feeding such a URL into WKWebView.startDownloadUsingRequest shouldn't crash.
It should fail gracefully like it used to.
* Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:
(WebKit::NetworkDataTaskCocoa::NetworkDataTaskCocoa):
Canonical link: https://commits.webkit.org/290857@main
To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications
More information about the webkit-changes
mailing list