[webkit-changes] [WebKit/WebKit] b47957: [ResourceMonitor] Add more meaningful release log ...

[Basuke Suzuki]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b47957d7891a2b461cf18eb5e627f8e368626905
      https://github.com/WebKit/WebKit/commit/b47957d7891a2b461cf18eb5e627f8e368626905
  Author: Basuke Suzuki <basuke at apple.com>
  Date:   2025-02-21 (Fri, 21 Feb 2025)

  Changed paths:
    M LayoutTests/http/tests/iframe-monitor/dark-mode-expected.txt
    M LayoutTests/http/tests/iframe-monitor/eligibility-expected.txt
    M LayoutTests/http/tests/iframe-monitor/iframe-unload-expected.txt
    M LayoutTests/http/tests/iframe-monitor/shared-worker-expected.txt
    M LayoutTests/http/tests/iframe-monitor/throttler-expected.txt
    M Source/WebCore/dom/Document.cpp
    M Source/WebCore/loader/ResourceLoadInfo.cpp
    M Source/WebCore/loader/ResourceLoadInfo.h
    M Source/WebCore/loader/ResourceMonitor.cpp
    M Source/WebCore/loader/ResourceMonitor.h
    M Source/WebCore/loader/ResourceMonitorChecker.cpp
    M Source/WebCore/loader/ResourceMonitorPersistence.cpp
    M Source/WebCore/loader/ResourceMonitorThrottler.cpp
    M Source/WebCore/page/LocalFrame.cpp
    M Source/WebCore/platform/Logging.h
    M Source/WebCore/workers/shared/SharedWorker.cpp

  Log Message:
  -----------
  [ResourceMonitor] Add more meaningful release log information part 1.
https://bugs.webkit.org/show_bug.cgi?id=288171
rdar://145259890

Reviewed by Per Arne Vollan and Chris Dumez.

Adding new log category and move current release logs to that category. And also add more meaningful information
for the record.

This is part 1, targeting WebCore.

In this change, chances are:
- URL checks are most of two times per each iframe.
- One check generates several logs.
- When it hits the network limits, some extra logs is produced.
- If unloading happens, ~10 more logs.

One exception is for shared worker, which logs all network usage and this will be rare case. In case it causes an issue,
this will be removed. For now, it is required to observe the usage during development.

* LayoutTests/http/tests/iframe-monitor/dark-mode-expected.txt:
* LayoutTests/http/tests/iframe-monitor/eligibility-expected.txt:
* LayoutTests/http/tests/iframe-monitor/iframe-unload-expected.txt:
* LayoutTests/http/tests/iframe-monitor/shared-worker-expected.txt:
* LayoutTests/http/tests/iframe-monitor/throttler-expected.txt:
* Source/WebCore/dom/Document.cpp:
(WebCore::Document::resourceMonitor):
* Source/WebCore/loader/ResourceLoadInfo.cpp:
(WebCore::ContentExtensions::resourceTypeToString):
* Source/WebCore/loader/ResourceLoadInfo.h:
* Source/WebCore/loader/ResourceMonitor.cpp:
(WebCore::ResourceMonitor::setEligibility):
(WebCore::ResourceMonitor::didReceiveResponse):
(WebCore::eligibilityToString):
(WebCore::ResourceMonitor::continueAfterDidReceiveEligibility):
* Source/WebCore/loader/ResourceMonitor.h:
* Source/WebCore/loader/ResourceMonitorChecker.cpp:
(WebCore::ResourceMonitorChecker::checkEligibility):
* Source/WebCore/loader/ResourceMonitorPersistence.cpp:
(WebCore::ResourceMonitorPersistence::reportSQLError):
(WebCore::ResourceMonitorPersistence::openDatabase):
* Source/WebCore/loader/ResourceMonitorThrottler.cpp:
(WebCore::ResourceMonitorThrottler::~ResourceMonitorThrottler):
(WebCore::ResourceMonitorThrottler::tryAccess):
* Source/WebCore/page/LocalFrame.cpp:
(WebCore::LocalFrame::showResourceMonitoringError):
(WebCore::LocalFrame::reportResourceMonitoringWarning):
* Source/WebCore/platform/Logging.h:
* Source/WebCore/workers/shared/SharedWorker.cpp:
(WebCore::SharedWorker::reportNetworkUsage):

Canonical link: https://commits.webkit.org/290850@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications