[webkit-changes] [WebKit/WebKit] dfb8e1: REGRESSION(290757 at main)[macOS Debug]: ASSERTION FA...

[Abrar Rahman Protyasha]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: dfb8e11413ac661a8edc3576a86443523218ed19
      https://github.com/WebKit/WebKit/commit/dfb8e11413ac661a8edc3576a86443523218ed19
  Author: Abrar Rahman Protyasha <a_protyasha at apple.com>
  Date:   2025-02-21 (Fri, 21 Feb 2025)

  Changed paths:
    M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm

  Log Message:
  -----------
  REGRESSION(290757 at main)[macOS Debug]: ASSERTION FAILED: ProcessCapabilities::canUseAcceleratedBuffers() in pdf tests (failure in EWS)
https://bugs.webkit.org/show_bug.cgi?id=288264
rdar://145334282

Reviewed by Richard Robinson.

We can't mix and match accelerated drawing, and accessing the platform
context, because this tries to map IOSurfaces into the web content
process, which is denied by the sandbox.

This patch corrects the minor typo in layerNeedsPlatformContext since we
want to return true if shouldUseInProcessBackingStore is true, and not
if it's false.

* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm:
(WebKit::UnifiedPDFPlugin::layerNeedsPlatformContext const):

Canonical link: https://commits.webkit.org/290841@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications