[webkit-changes] [WebKit/WebKit] 9996e4: [JSC] DirectArguments::visitChildrenImpl calls JSO...

[Yusuke Suzuki]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9996e4031b794c1c166ff57020304d56e55291f7
      https://github.com/WebKit/WebKit/commit/9996e4031b794c1c166ff57020304d56e55291f7
  Author: Yusuke Suzuki <ysuzuki at apple.com>
  Date:   2025-02-21 (Fri, 21 Feb 2025)

  Changed paths:
    M Source/JavaScriptCore/CMakeLists.txt
    M Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj
    M Source/JavaScriptCore/SaferCPPExpectations/MemoryUnsafeCastCheckerExpectations
    M Source/JavaScriptCore/runtime/DirectArguments.cpp
    M Source/JavaScriptCore/runtime/DirectArguments.h
    R Source/JavaScriptCore/runtime/GenericArguments.h
    A Source/JavaScriptCore/runtime/GenericArgumentsImpl.h
    A Source/JavaScriptCore/runtime/GenericArgumentsImplInlines.h
    R Source/JavaScriptCore/runtime/GenericArgumentsInlines.h
    M Source/JavaScriptCore/runtime/ScopedArguments.cpp
    M Source/JavaScriptCore/runtime/ScopedArguments.h

  Log Message:
  -----------
  [JSC] DirectArguments::visitChildrenImpl calls JSObject::visitChildrenImpl twice
https://bugs.webkit.org/show_bug.cgi?id=287502
rdar://145080419

Reviewed by Yijia Huang.

Avoid calling Base::visitChildren twice. We also rename GenericArguments
to GenericArgumentsImpl to make it clear that this is Impl interface for
JSCells.

* Source/JavaScriptCore/CMakeLists.txt:
* Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj:
* Source/JavaScriptCore/SaferCPPExpectations/MemoryUnsafeCastCheckerExpectations:
* Source/JavaScriptCore/runtime/DirectArguments.cpp:
(JSC::DirectArguments::DirectArguments):
(JSC::DirectArguments::visitChildrenImpl):
(JSC::DirectArguments::copyToArguments):
* Source/JavaScriptCore/runtime/DirectArguments.h:
* Source/JavaScriptCore/runtime/GenericArgumentsImpl.h: Renamed from Source/JavaScriptCore/runtime/GenericArguments.h.
(JSC::GenericArgumentsImpl::GenericArgumentsImpl):
* Source/JavaScriptCore/runtime/GenericArgumentsImplInlines.h: Renamed from Source/JavaScriptCore/runtime/GenericArgumentsInlines.h.
(JSC::GenericArgumentsImpl<Type>::visitChildrenImpl):
(JSC::GenericArgumentsImpl<Type>::getOwnPropertySlot):
(JSC::GenericArgumentsImpl<Type>::getOwnPropertySlotByIndex):
(JSC::GenericArgumentsImpl<Type>::getOwnPropertyNames):
(JSC::GenericArgumentsImpl<Type>::put):
(JSC::GenericArgumentsImpl<Type>::putByIndex):
(JSC::GenericArgumentsImpl<Type>::deleteProperty):
(JSC::GenericArgumentsImpl<Type>::deletePropertyByIndex):
(JSC::GenericArgumentsImpl<Type>::defineOwnProperty):
(JSC::GenericArgumentsImpl<Type>::initModifiedArgumentsDescriptor):
(JSC::GenericArgumentsImpl<Type>::initModifiedArgumentsDescriptorIfNecessary):
(JSC::GenericArgumentsImpl<Type>::setModifiedArgumentDescriptor):
(JSC::GenericArgumentsImpl<Type>::isModifiedArgumentDescriptor):
(JSC::GenericArgumentsImpl<Type>::copyToArguments):
* Source/JavaScriptCore/runtime/ScopedArguments.cpp:
(JSC::ScopedArguments::ScopedArguments):
(JSC::ScopedArguments::visitChildrenImpl):
(JSC::ScopedArguments::copyToArguments):
* Source/JavaScriptCore/runtime/ScopedArguments.h:

Canonical link: https://commits.webkit.org/290839@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications