[webkit-changes] [WebKit/WebKit] 5fb0bc: [Site Isolation] Session restore in a new WKWebVie...

[Charlie Wolfe]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5fb0bc3dd4265a5b0dc651012c01f532794531ce
      https://github.com/WebKit/WebKit/commit/5fb0bc3dd4265a5b0dc651012c01f532794531ce
  Author: Charlie Wolfe <charliew at apple.com>
  Date:   2025-02-21 (Fri, 21 Feb 2025)

  Changed paths:
    M Source/WebKit/UIProcess/WebPageProxy.cpp
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm

  Log Message:
  -----------
  [Site Isolation] Session restore in a new WKWebView breaks when restoring from an existing WKWebView
https://bugs.webkit.org/show_bug.cgi?id=288162
rdar://145257058

Reviewed by Alex Christensen.

There's logic in WebPageProxy::goToBackForwardItem to send FrameState to the right frame process, but we
didn’t check if the frame actually belonged to the current page. So, after restoring session state from
another WKWebView, we could end up trying to send FrameState to a process belonging to a different page.
We should make sure the frame belongs to the current page before sending IPC to its process.

* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::goToBackForwardItem):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm:
(TestWebKitAPI::TEST(SiteIsolation, RestoreSessionFromAnotherWebView)):

Canonical link: https://commits.webkit.org/290832@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications