[webkit-changes] [WebKit/WebKit] cd30f3: Address safer C++ static analysis warnings in WebL...

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cd30f3e2865d144bc855c91d6f77984e492d79f1
      https://github.com/WebKit/WebKit/commit/cd30f3e2865d144bc855c91d6f77984e492d79f1
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2025-02-21 (Fri, 21 Feb 2025)

  Changed paths:
    M Source/WebCore/loader/LocalFrameLoaderClient.h
    M Source/WebCore/page/Page.cpp
    M Source/WebCore/page/Page.h
    M Source/WebCore/platform/Widget.h
    M Source/WebCore/plugins/PluginViewBase.h
    M Source/WebKit/SaferCPPExpectations/MemoryUnsafeCastCheckerExpectations
    M Source/WebKit/SaferCPPExpectations/UncountedCallArgsCheckerExpectations
    M Source/WebKit/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations
    M Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp
    M Source/WebKit/WebProcess/Plugins/PluginView.h
    M Source/WebKit/WebProcess/WebCoreSupport/WebLocalFrameLoaderClient.cpp
    M Source/WebKit/WebProcess/WebCoreSupport/WebLocalFrameLoaderClient.h
    M Source/WebKit/WebProcess/WebCoreSupport/curl/WebFrameNetworkingContext.cpp
    M Source/WebKit/WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm
    M Source/WebKit/WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.cpp
    M Source/WebKit/WebProcess/WebPage/WebFrame.cpp
    M Source/WebKit/WebProcess/WebPage/WebPage.cpp

  Log Message:
  -----------
  Address safer C++ static analysis warnings in WebLocalFrameLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=288179

Reviewed by Ryosuke Niwa.

* Source/WebCore/loader/LocalFrameLoaderClient.h:
* Source/WebCore/page/Page.cpp:
(WebCore::Page::protectedPluginData):
* Source/WebCore/page/Page.h:
* Source/WebCore/platform/Widget.h:
(WebCore::Widget::isPluginView const):
* Source/WebCore/plugins/PluginViewBase.h:
(WebCore::PluginViewBase::isPluginView const): Deleted.
* Source/WebKit/SaferCPPExpectations/MemoryUnsafeCastCheckerExpectations:
* Source/WebKit/SaferCPPExpectations/UncountedCallArgsCheckerExpectations:
* Source/WebKit/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations:
* Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp:
(WebKit::WebLoaderStrategy::scheduleLoad):
(WebKit::WebLoaderStrategy::tryLoadingUsingURLSchemeHandler):
(WebKit::WebLoaderStrategy::scheduleLoadFromNetworkProcess):
(WebKit::WebLoaderStrategy::tryLoadingSynchronouslyUsingURLSchemeHandler):
(WebKit::WebLoaderStrategy::loadResourceSynchronously):
* Source/WebKit/WebProcess/Plugins/PluginView.h:
(isType):
* Source/WebKit/WebProcess/WebCoreSupport/WebLocalFrameLoaderClient.cpp:
(WebKit::WebLocalFrameLoaderClient::dispatchDidStartProvisionalLoad):
(WebKit::WebLocalFrameLoaderClient::dispatchDidFailProvisionalLoad):
(WebKit::WebLocalFrameLoaderClient::dispatchWillSendSubmitEvent):
(WebKit::WebLocalFrameLoaderClient::setMainDocumentError):
(WebKit::WebLocalFrameLoaderClient::updateGlobalHistoryRedirectLinks):
(WebKit::WebLocalFrameLoaderClient::loadStorageAccessQuirksIfNeeded):
(WebKit::WebLocalFrameLoaderClient::restoreViewState):
(WebKit::WebLocalFrameLoaderClient::updateCachedDocumentLoader):
(WebKit::WebLocalFrameLoaderClient::transitionToCommittedFromCachedFrame):
(WebKit::WebLocalFrameLoaderClient::transitionToCommittedForNewPage):
(WebKit::WebLocalFrameLoaderClient::createFrame):
(WebKit::WebLocalFrameLoaderClient::redirectDataToPlugin):
(WebKit::WebLocalFrameLoaderClient::objectContentType):
(WebKit::WebLocalFrameLoaderClient::overrideMediaType const):
(WebKit::WebLocalFrameLoaderClient::dispatchDidClearWindowObjectInWorld):
(WebKit::WebLocalFrameLoaderClient::contentFilterDidBlockLoad):
(WebKit::WebLocalFrameLoaderClient::shouldUsePDFPlugin const):
(WebKit::WebLocalFrameLoaderClient::isParentProcessAFullWebBrowser const):
(WebKit::WebLocalFrameLoaderClient::dispatchLoadEventToOwnerElementInAnotherProcess):
* Source/WebKit/WebProcess/WebCoreSupport/WebLocalFrameLoaderClient.h:
(isType):
(WebKit::toWebLocalFrameLoaderClient): Deleted.
* Source/WebKit/WebProcess/WebCoreSupport/curl/WebFrameNetworkingContext.cpp:
(WebKit::WebFrameNetworkingContext::webFrameLoaderClient const):
* Source/WebKit/WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:
(WebKit::WebFrameNetworkingContext::webFrameLoaderClient const):
* Source/WebKit/WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.cpp:
(WebKit::WebFrameNetworkingContext::webFrameLoaderClient const):
* Source/WebKit/WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::localFrameLoaderClient const):
(WebKit::WebFrame::frameLoaderClient const):
(WebKit::WebFrame::fromCoreFrame):
(WebKit::WebFrame::destroyProvisionalFrame):
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::mainFrameHasCustomContentProvider const):
(WebKit::WebPage::setUseIconLoadingClient):

Canonical link: https://commits.webkit.org/290817@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications