[webkit-changes] [WebKit/WebKit] 5125a9: Followup to 290754 at main — add a missing null check...

Wenson Hsieh noreply at github.com
Fri Feb 21 11:03:11 PST 2025


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5125a904535b3711de9c96710381231decc88d7d
      https://github.com/WebKit/WebKit/commit/5125a904535b3711de9c96710381231decc88d7d
  Author: Wenson Hsieh <wenson_hsieh at apple.com>
  Date:   2025-02-21 (Fri, 21 Feb 2025)

  Changed paths:
    M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm

  Log Message:
  -----------
  Followup to 290754 at main — add a missing null check for `WebPage`
https://bugs.webkit.org/show_bug.cgi?id=288145
rdar://142476781

Reviewed by Abrar Rahman Protyasha.

Add a missing null check for `webPage` before attempting to access it. This is purely a hardening
measure — I didn't hit this when testing manually, but since `WebFrame::m_page` is a weak pointer,
there doesn't seem to be any guarantee that the `WebPage` is non-null here.

* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm:
(WebKit::UnifiedPDFPlugin::handleMouseEvent):

Canonical link: https://commits.webkit.org/290811@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list