[webkit-changes] [WebKit/WebKit] 03eccf: [scroll-animations] WPT test scroll-animations/scr...

[Antoine Quint]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 03eccf44ee0d716d68e16dcdf4c0fa6a7b683c09
      https://github.com/WebKit/WebKit/commit/03eccf44ee0d716d68e16dcdf4c0fa6a7b683c09
  Author: Antoine Quint <graouts at webkit.org>
  Date:   2025-02-21 (Fri, 21 Feb 2025)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/scroll-animations/scroll-timelines/scroll-animation-effect-phases.tentative-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/web-animations/testcommon.js
    M Source/WebCore/animation/WebAnimation.cpp

  Log Message:
  -----------
  [scroll-animations] WPT test scroll-animations/scroll-timelines/scroll-animation-effect-phases.tentative.html has failures
https://bugs.webkit.org/show_bug.cgi?id=284545
rdar://problem/141356963

Reviewed by Anne van Kesteren.

The technique used by this test to determine the phase [0] in which an animation
is, which is not explicitly exposed via the Web Animations API, was not up-to-date
with the fact that progress-based animations remain active at the 100% boundary.

So we update the supporting `assert_phase()` function to deal with such animations
and pass the previously failing assertion.

But going further into this test, we would hit a debug assertion when trying to compute
the unconstrained current time as we get to the end of the procedure to set the timeline
as we move from the scroll timeline to the document timeline.

I filed a spec issue [1] to deal with this and came up with a temporary fix to restore
the timing incompatibility and pass this test.

[0] https://drafts.csswg.org/web-animations-1/#animation-effect-phases-and-states
[1] https://github.com/w3c/csswg-drafts/issues/11761

* LayoutTests/imported/w3c/web-platform-tests/scroll-animations/scroll-timelines/scroll-animation-effect-phases.tentative-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/web-animations/testcommon.js:
(assert_phase):
* Source/WebCore/animation/WebAnimation.cpp:
(WebCore::WebAnimation::setTimeline):

Canonical link: https://commits.webkit.org/290787@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications