[webkit-changes] [WebKit/WebKit] 8602df: [IFC] Do not attempt to repopulate breaking positi...

Alan Baradlay noreply at github.com
Fri Feb 21 05:23:19 PST 2025


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8602dfa92bbea787fa2459066c289a481033f478
      https://github.com/WebKit/WebKit/commit/8602dfa92bbea787fa2459066c289a481033f478
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2025-02-21 (Fri, 21 Feb 2025)

  Changed paths:
    M Source/WebCore/layout/formattingContexts/inline/InlineContentCache.h
    M Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp
    M Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.h
    M Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp

  Log Message:
  -----------
  [IFC] Do not attempt to repopulate breaking position cache with content that originated from this cache
https://bugs.webkit.org/show_bug.cgi?id=288116

Reviewed by Antti Koivisto.

While we don't actually end up repopulating the cache with existing content, we should not even
attempt to do it.

* Source/WebCore/layout/formattingContexts/inline/InlineContentCache.h:
(WebCore::Layout::InlineContentCache::InlineItems::isPopulatedFromCache const):
(WebCore::Layout::InlineContentCache::InlineItems::set):
(WebCore::Layout::InlineContentCache::InlineItems::replace):
* Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp:
(WebCore::Layout::InlineItemsBuilder::build):
(WebCore::Layout::InlineItemsBuilder::handleTextContent):
* Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.h:
* Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp:
(WebCore::LayoutIntegration::LineLayout::~LineLayout):

Canonical link: https://commits.webkit.org/290784@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list