[webkit-changes] [WebKit/WebKit] a303c0: Fix operator precedence in SizesCalcParser.cpp

Zak Ridouh noreply at github.com
Thu Feb 20 22:14:47 PST 2025


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a303c0e7ffc6a5b1441f70db397dd35aa337edb2
      https://github.com/WebKit/WebKit/commit/a303c0e7ffc6a5b1441f70db397dd35aa337edb2
  Author: Zak Ridouh <zakr at apple.com>
  Date:   2025-02-20 (Thu, 20 Feb 2025)

  Changed paths:
    M LayoutTests/css3/calc/calc-errors-expected.txt
    M LayoutTests/css3/calc/calc-errors.html
    M Source/WebCore/css/parser/SizesCalcParser.cpp

  Log Message:
  -----------
  Fix operator precedence in SizesCalcParser.cpp
https://bugs.webkit.org/show_bug.cgi?id=254697
<rdar://107681323>

Reviewed by Tim Nguyen.

Fix operator precedence in `SizesCalcParser.cpp` and write tests for it.
This improves size calculations and could improve experience on
mobile/tablets when rotating from landscape -> horizontal and viceversa.

Merge: https://chromium.googlesource.com/chromium/src.git/+/e0bcd910832c55445bc6bb4156acd716e0667248

Add in tests to `calc-errors.html` to verify this fix.

* LayoutTests/css3/calc/calc-errors-expected.txt:
* LayoutTests/css3/calc/calc-errors.html:
* Source/WebCore/css/parser/SizesCalcParser.cpp:
(WebCore::SizesCalcParser::handleOperator):

Canonical link: https://commits.webkit.org/290768@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list