[webkit-changes] [WebKit/WebKit] d7e26d: Implement support for setting dialog's returnValue...

[Luke Warlow]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d7e26d13ce41e3841ce00d005823ff78581bf02d
      https://github.com/WebKit/WebKit/commit/d7e26d13ce41e3841ce00d005823ff78581bf02d
  Author: Luke Warlow <lwarlow at igalia.com>
  Date:   2025-02-20 (Thu, 20 Feb 2025)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/html/semantics/the-button-element/command-and-commandfor/on-dialog-behavior.tentative-expected.txt
    M Source/WebCore/dom/Element.h
    M Source/WebCore/html/HTMLDialogElement.cpp
    M Source/WebCore/html/HTMLDialogElement.h
    M Source/WebCore/html/HTMLElement.cpp
    M Source/WebCore/html/HTMLElement.h

  Log Message:
  -----------
  Implement support for setting dialog's returnValue with command button's value
https://bugs.webkit.org/show_bug.cgi?id=287148

Reviewed by Basuke Suzuki.

The close command now correctly passes through the button's value to the close function,
this sets the dialog's returnValue property.

* LayoutTests/imported/w3c/web-platform-tests/html/semantics/the-button-element/command-and-commandfor/on-dialog-behavior.tentative-expected.txt:
* Source/WebCore/dom/Element.h:
(WebCore::Element::handleCommandInternal):
* Source/WebCore/html/HTMLDialogElement.cpp:
(WebCore::HTMLDialogElement::handleCommandInternal):
* Source/WebCore/html/HTMLDialogElement.h:
* Source/WebCore/html/HTMLElement.cpp:
(WebCore::HTMLElement::handleCommandInternal):
* Source/WebCore/html/HTMLElement.h:

Canonical link: https://commits.webkit.org/290767@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications