[webkit-changes] [WebKit/WebKit] f337e8: [XML Parser] Don't overwrite result of xmlGetPrede...

[Zak Ridouh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f337e8735a7df410fa90a1a34d0f9a18f39ed39b
      https://github.com/WebKit/WebKit/commit/f337e8735a7df410fa90a1a34d0f9a18f39ed39b
  Author: Zak Ridouh <zakr at apple.com>
  Date:   2025-02-20 (Thu, 20 Feb 2025)

  Changed paths:
    M Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp

  Log Message:
  -----------
  [XML Parser] Don't overwrite result of xmlGetPredefinedEntity
https://bugs.webkit.org/show_bug.cgi?id=288153
rdar://145249951

Reviewed by David Kilzer.

Currently, in `xmlGetPredefinedEntity` we overwrite the value of `ent->etype`,
which should always be of type `XML_INTERNAL_PREDEFINED_ENTITY`

We should use an ASSERT to verify that the result has the expected
type, and not overwrite it.

This allows libxml2 to change these variables to `const` without us
being impacted.

* Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp:
(WebCore::getEntityHandler):

Canonical link: https://commits.webkit.org/290765@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications