[webkit-changes] [WebKit/WebKit] edb3f0: [Site Isolation] Main frame history state may be i...

[Charlie Wolfe]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: edb3f0e437978ead3d1e0d358413fbc68e95cecf
      https://github.com/WebKit/WebKit/commit/edb3f0e437978ead3d1e0d358413fbc68e95cecf
  Author: Charlie Wolfe <charliew at apple.com>
  Date:   2025-02-20 (Thu, 20 Feb 2025)

  Changed paths:
    A LayoutTests/http/tests/site-isolation/history/add-iframes-and-navigate-mainframe-expected.txt
    A LayoutTests/http/tests/site-isolation/history/add-iframes-and-navigate-mainframe.html
    M Source/WebKit/UIProcess/WebPageProxy.cpp

  Log Message:
  -----------
  [Site Isolation] Main frame history state may be incorrectly created when navigating during iframe creation
https://bugs.webkit.org/show_bug.cgi?id=288073
rdar://145199120

Reviewed by Alex Christensen.

Site isolation introduces an unavoidable race condition where the history state committed by a web
process may have been created for a frame that the UI process has already destroyed. When this happens,
we should return early instead of adding an incorrect back/forward item.

* LayoutTests/http/tests/site-isolation/history/add-iframes-and-navigate-mainframe-expected.txt: Added.
* LayoutTests/http/tests/site-isolation/history/add-iframes-and-navigate-mainframe.html: Added.
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::backForwardAddItemShared):

Canonical link: https://commits.webkit.org/290724@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications