[webkit-changes] [WebKit/WebKit] 9daa0c: Remove FullscreenManager::m_topDocument

[Alex Christensen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9daa0ceb021d01d3496721cd4d3ccb277472ff11
      https://github.com/WebKit/WebKit/commit/9daa0ceb021d01d3496721cd4d3ccb277472ff11
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2025-02-19 (Wed, 19 Feb 2025)

  Changed paths:
    M Source/WebCore/dom/FullscreenManager.cpp
    M Source/WebCore/dom/FullscreenManager.h

  Log Message:
  -----------
  Remove FullscreenManager::m_topDocument
https://bugs.webkit.org/show_bug.cgi?id=287983
rdar://145153595

Reviewed by Tim Nguyen.

It is not needed and complicates state that I need to modify for site isolation
where the main frame doesn't have a document sometimes.  It isn't needed because
WebLocalFrameLoaderClient::dispatchDidStartProvisionalLoad closes fullscreen before
navigation. This is verified by the test fullscreen/fullscreen-iframe-navigation.html

* Source/WebCore/dom/FullscreenManager.cpp:
(WebCore::FullscreenManager::mainFrameDocument):
(WebCore::FullscreenManager::requestFullscreenForElement):
* Source/WebCore/dom/FullscreenManager.h:

Canonical link: https://commits.webkit.org/290648@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications