[webkit-changes] [WebKit/WebKit] f30180: Address safer C++ static analysis warnings in Scri...

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f301807828eb7d281b1e839a477cc38cd1f76071
      https://github.com/WebKit/WebKit/commit/f301807828eb7d281b1e839a477cc38cd1f76071
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2025-02-19 (Wed, 19 Feb 2025)

  Changed paths:
    M Source/JavaScriptCore/heap/Heap.cpp
    M Source/JavaScriptCore/heap/Heap.h
    M Source/WebCore/SaferCPPExpectations/NoUncountedMemberCheckerExpectations
    M Source/WebCore/SaferCPPExpectations/UncountedCallArgsCheckerExpectations
    M Source/WebCore/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations
    M Source/WebCore/bindings/js/DOMWrapperWorld.h
    M Source/WebCore/bindings/js/JSWindowProxy.cpp
    M Source/WebCore/bindings/js/JSWindowProxy.h
    M Source/WebCore/bindings/js/ScriptController.cpp
    M Source/WebCore/bindings/js/ScriptController.h
    M Source/WebCore/bindings/js/ScriptControllerMac.mm
    M Source/WebCore/bindings/js/WorkerScriptFetcher.h
    M Source/WebCore/dom/LoadableModuleScript.h
    M Source/WebCore/inspector/InspectorFrontendClientLocal.cpp
    M Source/WebCore/inspector/InspectorFrontendHost.cpp
    M Source/WebCore/workers/WorkerOrWorkletScriptController.cpp
    M Source/WebCore/workers/WorkerOrWorkletScriptController.h
    M Source/WebKitLegacy/mac/WebView/WebFrame.mm

  Log Message:
  -----------
  Address safer C++ static analysis warnings in ScriptController
https://bugs.webkit.org/show_bug.cgi?id=287931

Reviewed by Ryosuke Niwa.

* Source/JavaScriptCore/heap/Heap.cpp:
(JSC::Heap::protectedFullActivityCallback):
(JSC::Heap::protectedEdenActivityCallback):
* Source/JavaScriptCore/heap/Heap.h:
* Source/WebCore/bindings/js/DOMWrapperWorld.h:
(WebCore::debuggerWorldSingleton):
(WebCore::pluginWorldSingleton):
(WebCore::debuggerWorld): Deleted.
(WebCore::pluginWorld): Deleted.
* Source/WebCore/bindings/js/JSWindowProxy.cpp:
(WebCore::JSWindowProxy::protectedWrapped const):
* Source/WebCore/bindings/js/JSWindowProxy.h:
* Source/WebCore/bindings/js/ScriptController.cpp:
(WebCore::ScriptController::ScriptController):
(WebCore::ScriptController::~ScriptController):
(WebCore::ScriptController::linkAndEvaluateModuleScriptInWorld):
(WebCore::ScriptController::evaluateModule):
(WebCore::ScriptController::initScriptForWindowProxy):
(WebCore::ScriptController::jsWindowProxy):
(WebCore::ScriptController::eventHandlerPosition const):
(WebCore::ScriptController::canAccessFromCurrentOrigin):
(WebCore::ScriptController::cacheableBindingRootObject):
(WebCore::ScriptController::bindingRootObject):
(WebCore::ScriptController::protectedBindingRootObject):
(WebCore::ScriptController::createRootObject):
(WebCore::ScriptController::collectIsolatedContexts):
(WebCore::ScriptController::jsObjectForPluginElement):
* Source/WebCore/bindings/js/ScriptController.h:
* Source/WebCore/bindings/js/ScriptControllerMac.mm:
(WebCore::ScriptController::windowScriptObject):
(WebCore::ScriptController::javaScriptContext):
(WebCore::ScriptController::updatePlatformScriptObjects):
* Source/WebCore/bindings/js/WorkerScriptFetcher.h:
* Source/WebCore/dom/LoadableModuleScript.h:
* Source/WebCore/inspector/InspectorFrontendClientLocal.cpp:
(WebCore::InspectorFrontendClientLocal::windowObjectCleared):
* Source/WebCore/inspector/InspectorFrontendHost.cpp:
(WebCore::InspectorFrontendHost::showContextMenu):
* Source/WebCore/workers/WorkerOrWorkletScriptController.cpp:
(WebCore::WorkerOrWorkletScriptController::addTimerSetNotification):
(WebCore::WorkerOrWorkletScriptController::removeTimerSetNotification):
(WebCore::WorkerOrWorkletScriptController::evaluate):
(WebCore::WorkerOrWorkletScriptController::evaluateModule):
(WebCore::WorkerOrWorkletScriptController::loadModuleSynchronously):
(WebCore::WorkerOrWorkletScriptController::linkAndEvaluateModule):
(WebCore::WorkerOrWorkletScriptController::protectedGlobalScope const):
(WebCore::WorkerOrWorkletScriptController::loadAndEvaluateModule):
(WebCore::WorkerOrWorkletScriptController::initScriptWithSubclass):
* Source/WebCore/workers/WorkerOrWorkletScriptController.h:
* Source/WebKitLegacy/mac/WebView/WebFrame.mm:
(-[WebFrame _attachScriptDebugger]):

Canonical link: https://commits.webkit.org/290620@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications