[webkit-changes] [WebKit/WebKit] 4df703: Remove FullscreenManager::FullscreenPromise

[Alex Christensen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4df703fdc7cc8ca2f8371b7b260f66259def169b
      https://github.com/WebKit/WebKit/commit/4df703fdc7cc8ca2f8371b7b260f66259def169b
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2025-02-19 (Wed, 19 Feb 2025)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/fullscreen/api/document-exit-fullscreen-twice-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/screen-orientation/onchange-event-subframe-expected.txt
    R LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/fullscreen/api/document-exit-fullscreen-twice-expected.txt
    M Source/WebCore/dom/FullscreenManager.cpp
    M Source/WebCore/dom/FullscreenManager.h
    M Source/WebCore/page/ChromeClient.h
    M Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp
    M Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.h
    M Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp
    M Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h
    M Source/WebKit/WebProcess/WebCoreSupport/WebLocalFrameLoaderClient.cpp
    M Source/WebKitLegacy/mac/WebCoreSupport/WebChromeClient.h
    M Source/WebKitLegacy/mac/WebCoreSupport/WebChromeClient.mm
    M Source/WebKitLegacy/mac/WebCoreSupport/WebKitFullScreenListener.mm
    M Source/WebKitLegacy/mac/WebView/WebFullScreenController.h
    M Source/WebKitLegacy/mac/WebView/WebFullScreenController.mm
    M Source/WebKitLegacy/mac/WebView/WebView.mm
    M Source/WebKitLegacy/mac/WebView/WebViewInternal.h

  Log Message:
  -----------
  Remove FullscreenManager::FullscreenPromise
https://bugs.webkit.org/show_bug.cgi?id=287898
rdar://145092075

Reviewed by Eric Carlson.

The concept of storing the promise on the FullscreenManager was added in 257668 at main
to make sure it was called in all cases.  Now that I've gone through the entire flow
of entering and exiting fullscreen and used CompletionHandlers through the whole
flow, we can just pass along a CompletionHandler from begin to end of enter and exit.

* Source/WebCore/dom/FullscreenManager.cpp:
(WebCore::FullscreenManager::requestFullscreenForElement):
(WebCore::FullscreenManager::cancelFullscreen):
(WebCore::FullscreenManager::exitFullscreen):
(WebCore::FullscreenManager::willEnterFullscreen):
(WebCore::FullscreenManager::didExitFullscreen):
(WebCore::FullscreenManager::clear):
(WebCore::FullscreenManager::FullscreenPromise::~FullscreenPromise): Deleted.
(WebCore::FullscreenManager::FullscreenPromise::operator=): Deleted.
(WebCore::FullscreenManager::FullscreenPromise::clear): Deleted.
(WebCore::FullscreenManager::FullscreenPromise::resolve): Deleted.
(WebCore::FullscreenManager::FullscreenPromise::rejectOrResolve): Deleted.
(WebCore::FullscreenManager::FullscreenPromise::reject): Deleted.
(WebCore::FullscreenManager::FullscreenPromise::operator bool const): Deleted.
* Source/WebCore/dom/FullscreenManager.h:
* Source/WebCore/page/ChromeClient.h:
(WebCore::ChromeClient::exitFullScreenForElement):
* Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp:
(WebKit::WebFullScreenManager::exitFullScreenForElement):
(WebKit::WebFullScreenManager::willExitFullScreen):
(WebKit::WebFullScreenManager::didExitFullScreen):
* Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.h:
* Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::exitFullScreenForElement):
* Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h:
* Source/WebKit/WebProcess/WebCoreSupport/WebLocalFrameLoaderClient.cpp:
(WebKit::WebLocalFrameLoaderClient::dispatchDidStartProvisionalLoad):
* Source/WebKitLegacy/mac/WebCoreSupport/WebChromeClient.h:
* Source/WebKitLegacy/mac/WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::exitFullScreenForElement):
* Source/WebKitLegacy/mac/WebCoreSupport/WebKitFullScreenListener.mm:
(-[WebKitFullScreenListener webkitDidExitFullScreen]):
* Source/WebKitLegacy/mac/WebView/WebFullScreenController.h:
* Source/WebKitLegacy/mac/WebView/WebFullScreenController.mm:
(-[WebFullScreenController exitFullScreen:]):
(-[WebFullScreenController finishedExitFullScreenAnimation:]):
(-[WebFullScreenController close]):
(-[WebFullScreenController exitFullScreen]): Deleted.
* Source/WebKitLegacy/mac/WebView/WebView.mm:
(-[WebView _exitFullScreenForElement:completionHandler:]):
(-[WebView _exitFullScreenForElement:]): Deleted.
* Source/WebKitLegacy/mac/WebView/WebViewInternal.h:

Canonical link: https://commits.webkit.org/290619@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications