[webkit-changes] [WebKit/WebKit] 3c9719: [GTK][WPE] Use one fbo per render target instead o...

[Carlos Garcia Campos]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3c971961dbb013fd56c20ce20fee776f4c89ccee
      https://github.com/WebKit/WebKit/commit/3c971961dbb013fd56c20ce20fee776f4c89ccee
  Author: Carlos Garcia Campos <cgarcia at igalia.com>
  Date:   2025-02-19 (Wed, 19 Feb 2025)

  Changed paths:
    M Source/WebKit/WebProcess/WebPage/dmabuf/AcceleratedSurfaceDMABuf.cpp
    M Source/WebKit/WebProcess/WebPage/dmabuf/AcceleratedSurfaceDMABuf.h

  Log Message:
  -----------
  [GTK][WPE] Use one fbo per render target instead of a global one in AcceleratedSurfaceDMABuf
https://bugs.webkit.org/show_bug.cgi?id=287951

Reviewed by Nikolas Zimmermann.

Instead of changing the attachments of the fbo every time we render a
frame, we have one fbo per target where attachments are set once on
construction and then we just switch the current fbo before rendering a
new frame. This patch removes the intermediate class
RenderTargetColorBuffer and both RenderTargetEGLImage and
RenderTargetSHMImage create its own color buffer and attach it to the
fbo.

* Source/WebKit/WebProcess/WebPage/dmabuf/AcceleratedSurfaceDMABuf.cpp:
(WebKit::AcceleratedSurfaceDMABuf::RenderTarget::RenderTarget):
(WebKit::AcceleratedSurfaceDMABuf::RenderTarget::~RenderTarget):
(WebKit::AcceleratedSurfaceDMABuf::RenderTarget::willRenderFrame):
(WebKit::AcceleratedSurfaceDMABuf::RenderTarget::didRenderFrame):
(WebKit::AcceleratedSurfaceDMABuf::RenderTarget::setReleaseFenceFD):
(WebKit::AcceleratedSurfaceDMABuf::RenderTargetEGLImage::RenderTargetEGLImage):
(WebKit::AcceleratedSurfaceDMABuf::RenderTargetEGLImage::~RenderTargetEGLImage):
(WebKit::AcceleratedSurfaceDMABuf::RenderTargetSHMImage::RenderTargetSHMImage):
(WebKit::AcceleratedSurfaceDMABuf::RenderTargetSHMImage::~RenderTargetSHMImage):
(WebKit::AcceleratedSurfaceDMABuf::RenderTargetTexture::RenderTargetTexture):
(WebKit::AcceleratedSurfaceDMABuf::willDestroyGLContext):
(WebKit::AcceleratedSurfaceDMABuf::willRenderFrame):
(WebKit::AcceleratedSurfaceDMABuf::RenderTarget::willRenderFrame const): Deleted.
(WebKit::AcceleratedSurfaceDMABuf::RenderTarget::waitRelease): Deleted.
(WebKit::AcceleratedSurfaceDMABuf::RenderTargetColorBuffer::RenderTargetColorBuffer): Deleted.
(WebKit::AcceleratedSurfaceDMABuf::RenderTargetColorBuffer::~RenderTargetColorBuffer): Deleted.
(WebKit::AcceleratedSurfaceDMABuf::RenderTargetColorBuffer::willRenderFrame const): Deleted.
(WebKit::AcceleratedSurfaceDMABuf::RenderTargetTexture::willRenderFrame const): Deleted.
(WebKit::AcceleratedSurfaceDMABuf::didCreateGLContext): Deleted.
* Source/WebKit/WebProcess/WebPage/dmabuf/AcceleratedSurfaceDMABuf.h:

Co-authored-by: Nikolas Zimmermann <nzimmermann at igalia.com>
Canonical link: https://commits.webkit.org/290604@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications