[webkit-changes] [WebKit/WebKit] bf12ca: [scroll-animations] WPT test `scroll-animations/cs...

[Antoine Quint]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bf12caa476dbd8ee4dfb76b1b4568f874fe85a30
      https://github.com/WebKit/WebKit/commit/bf12caa476dbd8ee4dfb76b1b4568f874fe85a30
  Author: Antoine Quint <graouts at webkit.org>
  Date:   2025-02-19 (Wed, 19 Feb 2025)

  Changed paths:
    A LayoutTests/imported/w3c/web-platform-tests/css/css-overflow/scrollable-overflow-height-with-flex-item-margin-inline-end-rtl-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/css/css-overflow/scrollable-overflow-height-with-flex-item-margin-inline-end-rtl.html
    M LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/view-timeline-inset-animation-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/view-timeline-inset-animation.html

  Log Message:
  -----------
  [scroll-animations] WPT test `scroll-animations/css/view-timeline-inset-animation.html` is a failure
https://bugs.webkit.org/show_bug.cgi?id=287790

Reviewed by Anne van Kesteren.

We were failing the test `scroll-animations/css/view-timeline-inset-animation.html` because of how we handle `margin`
values to determine the offset width and height of the scrollable content. But the expected behavior is not strictly
specified by the css-overflow spec, per https://drafts.csswg.org/css-overflow-3/#scrollable:

> The UA may additionally include the margin areas of other boxes for which the box establishes
> a containing block; however, the conditions under which such margin areas are included is
> undefined in this level.

Additionally, the use of `margin` itself is not directly relevant to the test, but was just a test authoring decision
to easily place the view timeline subject in the center of a scrollable region. So we rewrite this WPT test to use
absolute positioning for the subject and explicit scrollable content sizing with an intermediate `#container` element.

Note that bringing our `margin` handling in line with Chrome and Firefox for interoperability reasons is covered by
https://bugs.webkit.org/show_bug.cgi?id=287802. A new WPT test is being added to `css/css-overflow` to cover such cases
so that we don't lose test coverage.

* LayoutTests/imported/w3c/web-platform-tests/css/css-overflow/scrollable-overflow-height-with-flex-item-margin-inline-end-rtl-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-overflow/scrollable-overflow-height-with-flex-item-margin-inline-end-rtl.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/view-timeline-inset-animation-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/view-timeline-inset-animation.html:

Canonical link: https://commits.webkit.org/290603@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications