[webkit-changes] [WebKit/WebKit] ff7fa0: [WebGPU] Retain Device for lifetime of its associa...

[mwyrzykowski]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ff7fa08bda15a39638b55d71ddfb7cbfd2d9a50c
      https://github.com/WebKit/WebKit/commit/ff7fa08bda15a39638b55d71ddfb7cbfd2d9a50c
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2025-02-18 (Tue, 18 Feb 2025)

  Changed paths:
    A LayoutTests/fast/webgpu/nocrash/fuzz-287868-expected.txt
    A LayoutTests/fast/webgpu/nocrash/fuzz-287868.html
    M Source/WebGPU/WebGPU/Instance.h
    M Source/WebGPU/WebGPU/Instance.mm
    M Source/WebGPU/WebGPU/Queue.mm

  Log Message:
  -----------
  [WebGPU] Retain Device for lifetime of its associated MTLCommandBuffer instances
https://bugs.webkit.org/show_bug.cgi?id=287868
rdar://145031314

Reviewed by Tadeu Zagallo.

To workaround rdar://143905417, manually retain the Device for the lifetime
of all the MTLCommandBuffers associated with it.

* LayoutTests/fast/webgpu/nocrash/fuzz-287868-expected.txt: Added.
* LayoutTests/fast/webgpu/nocrash/fuzz-287868.html: Added.
Add regression test.

* Source/WebGPU/WebGPU/Instance.h:
* Source/WebGPU/WebGPU/Instance.mm:
(WebGPU::Instance::retainDevice):
Store a container which maps a Device to all its pending MTLCommandBuffer instances.

* Source/WebGPU/WebGPU/Queue.mm:
(WebGPU::Queue::commandBufferWithDescriptor):
Retain on MTLCommandBuffer creation.

Canonical link: https://commits.webkit.org/290588@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications